linux-kernel - [PATCH] cpufreq: scpi-cpufreq: signedness bug in scpi_get_dvfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1450178204-26172-1-git-send-email-sudeep.holla@arm.com>
Date:	Tue, 15 Dec 2015 11:16:44 +0000
From:	Sudeep Holla <sudeep.holla@....com>
To:	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
	"Rafael J. Wysocki" <rjw@...ysocki.net>
Cc:	Viresh Kumar <viresh.kumar@...aro.org>,
	Dan Carpenter <dan.carpenter@...cle.com>
Subject: [PATCH] cpufreq: scpi-cpufreq: signedness bug in scpi_get_dvfs_info()

From: Dan Carpenter <dan.carpenter@...cle.com>

The "domain" variable needs to be signed for the error handling to work.

Fixes: 8def31034d03 ('cpufreq: arm_big_little: add SCPI interface driver')
Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
Acked-by: Viresh Kumar <viresh.kumar@...aro.org>
Acked-by: Sudeep Holla <sudeep.holla@....com>
---
 drivers/cpufreq/scpi-cpufreq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Hi Rafael,

This patch seem to have slipped through the cracks somehow. I don't see
in patchwork too. So I am resending so that you can pick for your next
rc fix if you plan to send one else for -next

Regards,
Sudeep

diff --git a/drivers/cpufreq/scpi-cpufreq.c b/drivers/cpufreq/scpi-cpufreq.c
index 2c3b16fd3a01..de5e89b2eaaa 100644
--- a/drivers/cpufreq/scpi-cpufreq.c
+++ b/drivers/cpufreq/scpi-cpufreq.c
@@ -31,7 +31,7 @@ static struct scpi_ops *scpi_ops;

 static struct scpi_dvfs_info *scpi_get_dvfs_info(struct device *cpu_dev)
 {
-	u8 domain = topology_physical_package_id(cpu_dev->id);
+	int domain = topology_physical_package_id(cpu_dev->id);

 	if (domain < 0)
 		return ERR_PTR(-EINVAL);
--
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/