linux-kernel - RE: [PATCH 3/9] Drivers: hv: utils: introduce HVUTIL_TRANSPORT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d165234a6e9a4340a421bf30c1dcc3ba@HKXPR3004MB0088.064d.mgd.msft.net>
Date:	Tue, 15 Dec 2015 12:14:53 +0000
From:	Dexuan Cui <decui@...rosoft.com>
To:	KY Srinivasan <kys@...rosoft.com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
	"olaf@...fle.de" <olaf@...fle.de>,
	"apw@...onical.com" <apw@...onical.com>,
	"vkuznets@...hat.com" <vkuznets@...hat.com>,
	"jasowang@...hat.com" <jasowang@...hat.com>
Subject: RE: [PATCH 3/9] Drivers: hv: utils: introduce
 HVUTIL_TRANSPORT_DESTROY mode

> -----Original Message-----
> From: devel [mailto:driverdev-devel-bounces@...uxdriverproject.org] On Behalf
> Of K. Y. Srinivasan
> Sent: Tuesday, December 15, 2015 11:02
> To: gregkh@...uxfoundation.org; linux-kernel@...r.kernel.org;
> devel@...uxdriverproject.org; olaf@...fle.de; apw@...onical.com;
> vkuznets@...hat.com; jasowang@...hat.com
> Subject: [PATCH 3/9] Drivers: hv: utils: introduce HVUTIL_TRANSPORT_DESTROY
> mode
> 
> From: Vitaly Kuznetsov <vkuznets@...hat.com>
> 
> When Hyper-V host asks us to remove some util driver by closing the
> appropriate channel there is no easy way to force the current file
> descriptor holder to hang up but we can start to respond -EBADF to all
> operations asking it to exit gracefully.
> 
> As we're setting hvt->mode from two separate contexts now we need to use
> a proper locking.
> 
> ...
> @@ -99,6 +107,10 @@ static unsigned int hvt_op_poll(struct file *file,
> poll_table *wait)
>  	hvt = container_of(file->f_op, struct hvutil_transport, fops);
> 
>  	poll_wait(file, &hvt->outmsg_q, wait);
> +
> +	if (hvt->mode == HVUTIL_TRANSPORT_DESTROY)
> +		return -EBADF;
> +
>  	if (hvt->outmsg_len > 0)
>  		return POLLIN | POLLRDNORM;

Hi Vitaly, 
Should hvt_op_poll() return -EBADF -- I think it probably
should return POLLERR or POLLHUP?

-- Dexuan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/