linux-kernel - Re: [PATCH 2/3] block: make blk-throttle.c explicitly non-modular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151215133058.GA20903@redhat.com>
Date:	Tue, 15 Dec 2015 08:30:58 -0500
From:	Vivek Goyal <vgoyal@...hat.com>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:	linux-kernel@...r.kernel.org, Jens Axboe <axboe@...nel.dk>,
	Tejun Heo <tj@...nel.org>
Subject: Re: [PATCH 2/3] block: make blk-throttle.c explicitly non-modular

Paul,

This looks reasonable to me. Ccing Tejun.

Thanks
Vivek

On Sun, Dec 13, 2015 at 03:04:03PM -0500, Paul Gortmaker wrote:
> The Kconfig currently controlling compilation of this code is:
> 
> config BLK_DEV_THROTTLING
>   bool "Block layer bio throttling support"
> 
> ...meaning that it currently is not being built as a module by anyone.
> 
> Lets remove the couple traces of modularity so that when reading the
> code there is no doubt it is builtin-only.
> 
> Since module_init translates to device_initcall in the non-modular
> case, the init ordering remains unchanged with this commit.
> 
> Cc: Vivek Goyal <vgoyal@...hat.com>
> Cc: Jens Axboe <axboe@...nel.dk>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
> ---
>  block/blk-throttle.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/block/blk-throttle.c b/block/blk-throttle.c
> index 2149a1ddbacf..bec1dedf4061 100644
> --- a/block/blk-throttle.c
> +++ b/block/blk-throttle.c
> @@ -4,7 +4,7 @@
>   * Copyright (C) 2010 Vivek Goyal <vgoyal@...hat.com>
>   */
>  
> -#include <linux/module.h>
> +#include <linux/init.h>
>  #include <linux/slab.h>
>  #include <linux/blkdev.h>
>  #include <linux/bio.h>
> @@ -1590,5 +1590,4 @@ static int __init throtl_init(void)
>  
>  	return blkcg_policy_register(&blkcg_policy_throtl);
>  }
> -
> -module_init(throtl_init);
> +device_initcall(throtl_init);
> -- 
> 2.6.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/