linux-kernel - Re: [PATCH] arm64: dts: berlin4ct: switch to Cortex-A53 specific pmu nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151215145243.GB7041@leverpostej>
Date:	Tue, 15 Dec 2015 14:52:43 +0000
From:	Mark Rutland <mark.rutland@....com>
To:	Jisheng Zhang <jszhang@...vell.com>
Cc:	Arnd Bergmann <arnd@...db.de>, sebastian.hesselbarth@...il.com,
	robh+dt@...nel.org, pawel.moll@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	catalin.marinas@....com, will.deacon@....com,
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: berlin4ct: switch to Cortex-A53 specific pmu
 nodes

On Tue, Dec 15, 2015 at 10:47:09PM +0800, Jisheng Zhang wrote:
> Dear Arnd,
> 
> On Tue, 15 Dec 2015 15:43:53 +0100 Arnd Bergmann wrote:
> 
> > On Tuesday 15 December 2015 22:36:12 Jisheng Zhang wrote:
> > > -               compatible = "arm,armv8-pmuv3";
> > > +               compatible = "arm,cortex-a53-pmu";
> > >   
> > 
> > Should this list both?
> 
> IMHO, we don't need to list both. The pmu binding document also says:
> "compatible : should be one of ...."
> 
> Dear Mark,
> 
> Could you please give suggestions?

That should probably reads as "should contain at least one of".

It's probably best to keep "arm,armv8-pmuv3" as a fallback in the
compatible list.

Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/