linux-kernel - Re: [PATCH v2] extcon: add Maxim MAX3355 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <567065F3.6010009@cogentembedded.com>
Date:	Tue, 15 Dec 2015 22:11:47 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Chanwoo Choi <cw00.choi@...sung.com>, robh+dt@...nel.org,
	pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	myungjoo.ham@...sung.com, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Cc:	linux-sh@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH v2] extcon: add Maxim MAX3355 driver

On 12/15/2015 04:20 AM, Chanwoo Choi wrote:

>> Maxim  Integrated MAX3355E chip integrates a  charge pump and comparators to
>         ^^                                     ^^
>> enable a system with an integrated USB OTG dual-role transceiver to function
>> as  an USB  OTG dual-role device.  In addition  to sensing/controlling Vbus,
>      ^^      ^^                     ^^           ^^
>> the chip also passes thru the ID signal  from the USB  OTG connector.
>                                           ^^
>> On some Renesas boards,  this signal is  just fed into the SoC thru a GPIO
>                           ^^              ^^
>> pin --  there's no real  OTG controller, only host and gadget USB controllers
>          ^^               ^^
>> sharing the same USB bus; however, we'd  like to allow host or gadget drivers
>                                           ^^
>> to be loaded depending on the cable type,  hence the need for the MAX3355
>                                             ^^
>> extcon driver. The Vbus status signals are also  wired to GPIOs (however, we
>> aren't currently interested in them),  the OFFVBUS# signal is controlled  by
>                                         ^^                                 ^^
>> the host controllers, there's  also the SHDN# signal wired to a GPIO, it
>                                 ^^
>> should be driven high for the  normal operation.
>                                 ^^
> As above '^' expression, you used the double space between words.
> You should fix it.

    OK, since so many people seem to be offended by that, I'll fix it. 
Meanwhile, please comment on the patch itself.

> Thanks,
> Chanwoo Choi
[...]

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/