linux-kernel - Re: [PATCH/RFC 11/16] perf top: Implement basic parallel processing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151215020824.GC32522@danjae.kornet>
Date:	Tue, 15 Dec 2015 11:08:24 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	LKML <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Andi Kleen <andi@...stfloor.org>,
	Stephane Eranian <eranian@...gle.com>,
	Adrian Hunter <adrian.hunter@...el.com>
Subject: Re: [PATCH/RFC 11/16] perf top: Implement basic parallel processing

On Mon, Dec 14, 2015 at 10:35:19AM +0100, Jiri Olsa wrote:
> On Mon, Dec 14, 2015 at 10:23:43AM +0100, Jiri Olsa wrote:
> > On Thu, Dec 10, 2015 at 04:53:30PM +0900, Namhyung Kim wrote:
> > 
> > SNIP
> > 
> > >  
> > > -	perf_top__mmap_read(top);
> > > -
> > >  	ret = -1;
> > > -	if (pthread_create(&thread, NULL, (use_browser > 0 ? display_thread_tui :
> > > -							    display_thread), top)) {
> > > -		ui__error("Could not create display thread.\n");
> > > +	readers = calloc(sizeof(pthread_t), top->evlist->nr_mmaps);
> > > +	if (readers == NULL)
> > >  		goto out_delete;
> > > -	}
> > >  
> > > -	if (top->realtime_prio) {
> > > -		struct sched_param param;
> > > +	rargs = calloc(sizeof(*rargs), top->evlist->nr_mmaps);
> > > +	if (rargs == NULL)
> > > +		goto out_free;
> > >  
> > > -		param.sched_priority = top->realtime_prio;
> > > -		if (sched_setscheduler(0, SCHED_FIFO, &param)) {
> > > -			ui__error("Could not set realtime priority.\n");
> > > -			goto out_join;
> > > -		}
> > > +	hists = calloc(sizeof(*hists), top->evlist->nr_mmaps * top->evlist->nr_entries);
> > > +	if (hists == NULL)
> > > +		goto out_free;
> > > +
> > > +	for (i = 0; i < top->evlist->nr_mmaps * top->evlist->nr_entries; i++)
> > > +		__hists__init(&hists[i]);
> > > +
> > > +	for (i = 0; i < top->evlist->nr_mmaps; i++) {
> > > +		struct reader_arg *rarg = &rargs[i];
> > > +
> > > +		rarg->idx = i;
> > > +		rarg->top = top;
> > > +		rarg->hists = &hists[i * top->evlist->nr_entries];
> > > +
> > > +		perf_top__mmap_read(rarg);
> > >  	}
> > > +	collect_hists(top, hists);
> > 
> > hum, what's the reason for calling perf_top__mmap_read
> > and collect_hists in here?
> 
> nah it's for initial data so ui thread has something to display right? ;-)

Right, the logic was already there.  Without it, the initial update
(after 2 seconds) looks too long for users.


> 
> > 
> > also calling collect_hists on hists array pointer seems wrong
> 
> still 'collect_hists(&hists[0]);' would seem more review friendly

Will change!

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/