linux-kernel - Re: [PATCH trivial] include: asm-generic: Notice about 80 columns in pgtable-no*.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56708ED4.30403@emindsoft.com.cn>
Date:	Wed, 16 Dec 2015 06:06:12 +0800
From:	Chen Gang <chengang@...ndsoft.com.cn>
To:	Joe Perches <joe@...ches.com>, Arnd Bergmann <arnd@...db.de>,
	trivial@...nel.org
CC:	Linux-Arch <linux-arch@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH trivial] include: asm-generic: Notice about 80 columns
 in pgtable-no*.h


On 12/16/15 04:26, Joe Perches wrote:
> On Tue, 2015-12-15 at 22:15 +0800, Chen Gang wrote:
>> It is a trivial patch.
> []
>> diff --git a/include/asm-generic/pgtable-nopmd.h b/include/asm-generic/pgtable-nopmd.h
> []
>> @@ -38,7 +38,8 @@ static inline void pud_clear(pud_t *pud)	{ }
>>   * (pmds are folded into puds so this doesn't get actually called,
>>   * but the define is needed for a generic inline function.)
>>   */
>> -#define set_pud(pudptr, pudval)			set_pmd((pmd_t *)(pudptr), (pmd_t) { pudval })
>> +#define set_pud(pudptr, pudval)			(set_pmd((pmd_t *)(pudptr), \
>> +							(pmd_t) { pudval }))
> 
> Not quite so trivial.
> 
> If you _really_ want to break this up for 80 columns,
> and I don't think it's necessary, it might be better
> to use something like:
> 
> #define set_pud(pudptr, pudval)					\
> 	set_pmd((pmd_t *)(pudptr), (pmd_t) { pudval })
>

OK, thanks. For me, it is better. 

-- 
Chen Gang (陈刚)

Open, share, and attitude like air, water, and life which God blessed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/