linux-kernel - Re: [PATCH] net: fix uninitialized variable issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5670973C.7030406@intel.com>
Date:	Tue, 15 Dec 2015 14:42:04 -0800
From:	Tadeusz Struk <tadeusz.struk@...el.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	herbert@...dor.apana.org.au, davem@...emloft.net,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org, freude@...ux.vnet.ibm.com,
	viro@...iv.linux.org.uk, linux-crypto@...r.kernel.org
Subject: Re: [PATCH] net: fix uninitialized variable issue

On 12/15/2015 11:02 AM, Eric Dumazet wrote:
> On Tue, 2015-12-15 at 10:46 -0800, Tadeusz Struk wrote:
>> msg_iocb needs to be initialized on the recv/recvfrom path.
>> Otherwise afalg will wrongly interpret it as an async call.
>>
>> Cc: stable@...r.kernel.org
>> Reported-by: Harald Freudenberger <freude@...ux.vnet.ibm.com>
>> Signed-off-by: Tadeusz Struk <tadeusz.struk@...el.com>
>> ---
>>  net/socket.c |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/net/socket.c b/net/socket.c
>> index dd2c247..80ca820 100644
>> --- a/net/socket.c
>> +++ b/net/socket.c
>> @@ -1702,6 +1702,7 @@ SYSCALL_DEFINE6(recvfrom, int, fd, void __user *, ubuf, size_t, size,
>>  	msg.msg_name = addr ? (struct sockaddr *)&address : NULL;
>>  	/* We assume all kernel code knows the size of sockaddr_storage */
>>  	msg.msg_namelen = 0;
>> +	msg.msg_iocb = NULL;
>>  	if (sock->file->f_flags & O_NONBLOCK)
>>  		flags |= MSG_DONTWAIT;
>>  	err = sock_recvmsg(sock, &msg, iov_iter_count(&msg.msg_iter), flags);
>>
> 
> Do not add "Cc: stable@...r.kernel.org" for networking patches, thanks 
> ( Documentation/networking/netdev-FAQ.txt )
> 
> Do you know when was this bug added ?
> 
> Please add the 
> 
> Fixes:  12-digit-sha1 ("patch title")
> 

It was added in this commit: 0345f93138b2 ("net: socket: add support for async operations")

Thanks
-- 
TS
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/