linux-kernel - Re: [PATCH 1/1] powerpc/irq: tidy up inconsistent context in migrate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <878u4vapsm.fsf@gamma.ozlabs.ibm.com>
Date:	Wed, 16 Dec 2015 17:08:41 +1100
From:	Daniel Axtens <dja@...ens.net>
To:	Zhang Zhuoyu <hellozzy1988@....com>, benh@...nel.crashing.org,
	paulus@...ba.org, mpe@...erman.id.au, tglx@...utronix.de,
	jiang.liu@...ux.intel.com, zhangzhuoyu@...s.chinamobile.com
Cc:	linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] powerpc/irq: tidy up inconsistent context in migrate_irqs()


Hi,

A couple of things.

Firstly, your two email addresses don't match:

Zhang Zhuoyu <hellozzy1988@....com> writes:
> From: Zhang Zhuoyu <zhangzhuoyu@...s.chinamobile.com>

These lines do seem odd! Are they causing a problem?

I'd be more comfortable removing them if I understood why they were
added. But they've been around since the beginning of git history so
that could be a bit difficult.

Instead, would it be possible to make sure this doesn't break anything
by including some test results?

Thanks,
Daniel

> Remove paradoxical and unnecessary lines before disable local interrupt.
>
> Signed-off-by: Zhang Zhuoyu <zhangzhuoyu@...s.chinamobile.com>
> ---
>  arch/powerpc/kernel/irq.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/arch/powerpc/kernel/irq.c b/arch/powerpc/kernel/irq.c
> index 290559d..03fa686 100644
> --- a/arch/powerpc/kernel/irq.c
> +++ b/arch/powerpc/kernel/irq.c
> @@ -454,8 +454,6 @@ void migrate_irqs(void)
>  
>  	free_cpumask_var(mask);
>  
> -	local_irq_enable();
> -	mdelay(1);
>  	local_irq_disable();
>  }
>  #endif
> -- 
> 1.8.3.1
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/