linux-kernel - Re: [PATCH RFC] memory-hotplug: add automatic onlining policy for the newly added memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87k2oevjkn.fsf@vitty.brq.redhat.com>
Date:	Wed, 16 Dec 2015 10:17:28 +0100
From:	Vitaly Kuznetsov <vkuznets@...hat.com>
To:	Xishi Qiu <qiuxishi@...wei.com>
Cc:	<linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>,
	<linux-doc@...r.kernel.org>, Jonathan Corbet <corbet@....net>,
	"Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
	Daniel Kiper <daniel.kiper@...cle.com>,
	Dan Williams <dan.j.williams@...el.com>,
	Tang Chen <tangchen@...fujitsu.com>,
	David Vrabel <david.vrabel@...rix.com>,
	"David Rientjes" <rientjes@...gle.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Naoya Horiguchi <n-horiguchi@...jp.nec.com>,
	Gu Zheng <guz.fnst@...fujitsu.com>,
	Mel Gorman <mgorman@...hsingularity.net>,
	"K. Y. Srinivasan" <kys@...rosoft.com>,
	yanxiaofeng <yanxiaofeng@...pur.com>,
	Changsheng Liu <liuchangsheng@...pur.com>,
	Kay Sievers <kay@...y.org>
Subject: Re: [PATCH RFC] memory-hotplug: add automatic onlining policy for the newly added memory

Xishi Qiu <qiuxishi@...wei.com> writes:

> On 2015/12/16 2:05, Vitaly Kuznetsov wrote:
>
>> Currently, all newly added memory blocks remain in 'offline' state unless
>> someone onlines them, some linux distributions carry special udev rules
>> like:
>> 
>> SUBSYSTEM=="memory", ACTION=="add", ATTR{state}=="offline", ATTR{state}="online"
>> 
>> to make this happen automatically. This is not a great solution for virtual
>> machines where memory hotplug is being used to address high memory pressure
>> situations as such onlining is slow and a userspace process doing this
>> (udev) has a chance of being killed by the OOM killer as it will probably
>> require to allocate some memory.
>> 
>> Introduce default policy for the newly added memory blocks in
>> /sys/devices/system/memory/hotplug_autoonline file with two possible
>> values: "offline" (the default) which preserves the current behavior and
>> "online" which causes all newly added memory blocks to go online as
>> soon as they're added.
>> 
>> Cc: Jonathan Corbet <corbet@....net>
>> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>> Cc: Daniel Kiper <daniel.kiper@...cle.com>
>> Cc: Dan Williams <dan.j.williams@...el.com>
>> Cc: Tang Chen <tangchen@...fujitsu.com>
>> Cc: David Vrabel <david.vrabel@...rix.com>
>> Cc: David Rientjes <rientjes@...gle.com>
>> Cc: Andrew Morton <akpm@...ux-foundation.org>
>> Cc: Naoya Horiguchi <n-horiguchi@...jp.nec.com>
>> Cc: Gu Zheng <guz.fnst@...fujitsu.com>
>> Cc: Xishi Qiu <qiuxishi@...wei.com>
>> Cc: Mel Gorman <mgorman@...hsingularity.net>
>> Cc: "K. Y. Srinivasan" <kys@...rosoft.com>
>> Signed-off-by: Vitaly Kuznetsov <vkuznets@...hat.com>
>> ---
>> - I was able to find previous attempts to fix the issue, e.g.:
>>   http://marc.info/?l=linux-kernel&m=137425951924598&w=2
>>   http://marc.info/?l=linux-acpi&m=127186488905382
>>   but I'm not completely sure why it didn't work out and the solution
>>   I suggest is not 'smart enough', thus 'RFC'.
>
> + CC: 
> yanxiaofeng@...pur.com
> liuchangsheng@...pur.com
>
> Hi Vitaly,
>
> Why not use udev rule? I think it can online pages automatically.
>

Two main reasons:
1) I remember someone saying "You never need a mouse in order to add
another mouse to the kernel" -- but we  we need memory to add more
memory. Udev has a chance of being killed by the OOM killer as
performing an action will probably require to allocate some
memory. Other than that udev actions are generally slow compared to what
we can do in kernel.

2) I agree with Kay that '... unconditional hotplug loop through
userspace is absolutely pointless' (https://lkml.org/lkml/2013/7/25/354). 
(... and I should had add him to CC, adding now). Udev maintainers
refused to add a rule for unconditional memory onlining to udev and now
linux distros have to carry such custom rules.

-- 
  Vitaly
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/