linux-kernel - Re: [RFC][PATCH v3] timekeeping: Cap adjustments so they don't exceed the maxadj value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151216101449.GA6207@localhost>
Date:	Wed, 16 Dec 2015 11:14:49 +0100
From:	Miroslav Lichvar <mlichvar@...hat.com>
To:	John Stultz <john.stultz@...aro.org>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Richard Cochran <richardcochran@...il.com>,
	Prarit Bhargava <prarit@...hat.com>,
	Andy Lutomirski <luto@...nel.org>
Subject: Re: [RFC][PATCH v3] timekeeping: Cap adjustments so they don't
 exceed the maxadj value

On Tue, Dec 15, 2015 at 09:48:06PM -0800, John Stultz wrote:
> Thus its been occasionally noted that users have seen
> confusing warnings like:
> 
>     Adjusting tsc more than 11% (5941981 vs 7759439)

> v2: Catch single unit adjustment that was being made
>     repeatedly to push us past the limit, as pointed
>     out by Miroslav.
> v3: Fix off-by-one case that could result in warning
>     still triggering, pointed out by Miroslav.

Looks good to me. There are no warnings in the simulator and chronyd
still seems to be working as expected.

Tested-by: Miroslav Lichvar <mlichvar@...hat.com>

-- 
Miroslav Lichvar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/