linux-kernel - Re: [PATCH v5 12/14] perf data: Support converting data from bpf_perf_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151216112935.GB6882@krava.brq.redhat.com>
Date:	Wed, 16 Dec 2015 12:29:35 +0100
From:	Jiri Olsa <jolsa@...hat.com>
To:	Wang Nan <wangnan0@...wei.com>
Cc:	acme@...nel.org, masami.hiramatsu.pt@...achi.com, jolsa@...nel.org,
	linux-kernel@...r.kernel.org, pi3orama@....com, lizefan@...wei.com,
	Alexei Starovoitov <ast@...nel.org>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Brendan Gregg <brendan.d.gregg@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Namhyung Kim <namhyung@...nel.org>
Subject: Re: [PATCH v5 12/14] perf data: Support converting data from
 bpf_perf_event_output()

On Mon, Dec 14, 2015 at 10:39:21AM +0000, Wang Nan wrote:

SNIP

> +	}
> +
> +	ret = bt_ctf_event_set_payload(event, "raw_data", seq_field);
> +	if (ret)
> +		pr_err("failed to set payload for raw_data\n");
> +
> +put_seq_field:
> +	bt_ctf_field_put(seq_field);
> +put_seq_type:
> +	bt_ctf_field_type_put(seq_type);
> +put_len_field:
> +	bt_ctf_field_put(len_field);
> +put_len_type:
> +	bt_ctf_field_type_put(len_type);
> +	return ret;
> +}
> +
>  static int add_generic_values(struct ctf_writer *cw,
>  			      struct bt_ctf_event *event,
>  			      struct perf_evsel *evsel,
> @@ -597,6 +675,13 @@ static int process_sample_event(struct perf_tool *tool,
>  			return -1;
>  	}
>  
> +	if ((evsel->attr.type == PERF_TYPE_SOFTWARE) &&
> +	    (evsel->attr.config == PERF_COUNT_SW_BPF_OUTPUT)) {

seen this condition at least on 3 places, maybe we could add it in:

bool perf_evsel__is_bpf_output(struct perf_evsel *evsel);


jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/