linux-kernel - Re: [PATCH] i2c: designware: Add support for AMD Seattle I2C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 15 Dec 2015 20:14:34 -0600
From:	Suravee Suthikulpanit <Suravee.Suthikulpanit@....com>
To:	<mika.westerberg@...ux.intel.com>, <wsa@...-dreams.de>
CC:	<linux-i2c@...r.kernel.org>, <linux-acpi@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] i2c: designware: Add support for AMD Seattle I2C

Hi Mika,

On 12/15/15 15:55, Suravee Suthikulpanit wrote:
> Add device HID AMDI0510 to match the I2C controlers on AMD Seattle platform
>
> Signed-off-by: Suravee Suthikulpanit <Suravee.Suthikulpanit@....com>
> ---
>   drivers/i2c/busses/i2c-designware-platdrv.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
> index 57f623b..a027154 100644
> --- a/drivers/i2c/busses/i2c-designware-platdrv.c
> +++ b/drivers/i2c/busses/i2c-designware-platdrv.c
> @@ -117,6 +117,7 @@ static const struct acpi_device_id dw_i2c_acpi_match[] = {
>   	{ "80860F41", 0 },
>   	{ "808622C1", 0 },
>   	{ "AMD0010", 0 },
> +	{ "AMDI0510", 0 },
>   	{ }

Since this driver seems to be used by several SOCs, and we have been 
adding the HID from various SOC vendors. Do you think it would be better 
to assign a CID so that each SOC vendor can specify in their ACPI DSDT 
and we can match them here?

Then, we can also associate the FMCN and SSCN along with the CID, and 
guarantee compatibility.

Thanks,
Suravee

>   };
>   MODULE_DEVICE_TABLE(acpi, dw_i2c_acpi_match);
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/