linux-kernel - Re: [PATCH 1/3] STAGING: COMEDI: Fixed format of comments in plx9080.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 16 Dec 2015 18:41:03 +0000
From:	Ian Abbott <abbotti@....co.uk>
To:	Moritz König <moritz.koenig@....de>,
	H Hartley Sweeten <hsweeten@...ionengravers.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Cc:	Fabian Lang <fabian.lang@....de>, linux-kernel@...cs.fau.de
Subject: Re: [PATCH 1/3] STAGING: COMEDI: Fixed format of comments in
 plx9080.h

On 12/12/15 17:09, Moritz König wrote:
> This patch fixes the format of comments in plx9080.h.
>
> Signed-off-by: Moritz König <moritz.koenig@....de>
> Signed-off-by: Fabian Lang <fabian.lang@....de>
> ---
>   drivers/staging/comedi/drivers/plx9080.h | 132 ++++++++++++++++++++++---------
>   1 file changed, 95 insertions(+), 37 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/plx9080.h b/drivers/staging/comedi/drivers/plx9080.h
> index 2570653..40514f7 100644
> --- a/drivers/staging/comedi/drivers/plx9080.h
> +++ b/drivers/staging/comedi/drivers/plx9080.h
> @@ -34,7 +34,8 @@ struct plx_dma_desc {
>   	/* transfer_size is in bytes, only first 23 bits of register are used */
>   	__le32 transfer_size;
>   	/* address of next descriptor (quad word aligned), plus some
> -	 * additional bits (see PLX_DMA0_DESCRIPTOR_REG) */
> +	 * additional bits (see PLX_DMA0_DESCRIPTOR_REG)
> +	 */
>   	__le32 next;

We prefer the usual block comment style:

	/*
	 * Like
	 * this
	 */

>   };
>
> @@ -46,23 +47,38 @@ struct plx_dma_desc {
>   **
>   **********************************************************************/
>
> -#define PLX_LAS0RNG_REG         0x0000	/* L, Local Addr Space 0 Range Register */
> -#define PLX_LAS1RNG_REG         0x00f0	/* L, Local Addr Space 1 Range Register */
> +#define PLX_LAS0RNG_REG         0x0000	/* L, Local Addr Space 0 Range
> +					 * Register
> +					 */
> +#define PLX_LAS1RNG_REG         0x00f0	/* L, Local Addr Space 1 Range
> +					 * Register
> +					 */

I suggest moving such comments that would wrap over 80 columns onto the 
previous line, like this:

/* L, Local Addr Space 0 Range Register */
#define PLX_LAS0RNG_REG         0x0000
/* L, Local Addr Space 1 Range Register */
#define PLX_LAS1RNG_REG 0x00f0

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/