linux-kernel - Re: [PATCH v4] perf: bpf: Fix build breakage due to libbpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 16 Dec 2015 16:42:34 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	"Naveen N. Rao" <naveen.n.rao@...ux.vnet.ibm.com>
Cc:	Wang Nan <wangnan0@...wei.com>, jolsa@...hat.com,
	linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
	sukadev@...ux.vnet.ibm.com
Subject: Re: [PATCH v4] perf: bpf: Fix build breakage due to libbpf

Em Tue, Dec 15, 2015 at 05:10:46PM +0530, Naveen N. Rao escreveu:
> On 2015/12/15 08:51AM, Wang Nan wrote:
> > From: "Naveen N. Rao" <naveen.n.rao@...ux.vnet.ibm.com>
> > 
> > perf build is currently (v4.4-rc5) broken on powerpc:
> > 
> > bpf.c:28:4: error: #error __NR_bpf not defined. libbpf does not support
> > your arch.
> >  #  error __NR_bpf not defined. libbpf does not support your arch.
> >     ^
> > 
> > Fix this by including tools/scripts/Makefile.arch for the proper
> > $ARCH macro. While at it, remove redundant LP64 macro definition.
> > 
> > Also, since libbpf require $(srctree) now, detect the path of
> > srctree like perf.
> > 
> > Signed-off-by: Naveen N. Rao <naveen.n.rao@...ux.vnet.ibm.com>
> > Signed-off-by: Wang Nan <wangnan0@...wei.com>
> > Acked-by: Jiri Olsa <jolsa@...nel.org>
> > Cc: Arnaldo Carvalho de Melo <acme@...nel.org>
> > Cc: Sukadev Bhattiprolu <sukadev@...ux.vnet.ibm.com>
> > ---
> > 
> > v3 -> v4: Add srctree detector code so directly run 'make' in libbpf
> >           directory would not cause error.
> 
> Good catch!
> 
> Tested-by: Naveen N. Rao <naveen.n.rao@...ux.vnet.ibm.com>

Trying to apply the patchkit:

[acme@zoo linux]$ make -C tools clean > /dev/null 2>&1
[acme@zoo linux]$ make -C tools/perf build-test
make: Entering directory '/home/git/linux/tools/perf'
Testing Makefile
tests/make:15: /scripts/Makefile.arch: No such file or directory
make[2]: *** No rule to make target '/scripts/Makefile.arch'.  Stop.
tests/make:5: recipe for target 'all' failed
make[1]: *** [all] Error 2
Makefile:81: recipe for target 'build-test' failed
make: *** [build-test] Error 2
make: Leaving directory '/home/git/linux/tools/perf'
[acme@zoo linux]$

What am I doing wrong?

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/