linux-kernel - Re: [PATCH 1/2] arm64: Improve error reporting on set_pte_at() checks

Open Source and information security mailing list archives

Message-ID: <CA+=Sn1kQBoLCY_AidPXPU-2dkqGcfDfZtcnk1gzEukttZ+foOQ@mail.gmail.com>
Date:	Tue, 15 Dec 2015 19:01:57 -0800
From:	Andrew Pinski <pinskia@...il.com>
To:	Catalin Marinas <catalin.marinas@....com>,
	LKML <linux-kernel@...r.kernel.org>
Cc:	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Andrew Pinski <apinski@...ium.com>,
	Ming Lei <tom.leiming@...il.com>,
	Will Deacon <will.deacon@....com>,
	David Daney <ddaney@...iumnetworks.com>
Subject: Re: [PATCH 1/2] arm64: Improve error reporting on set_pte_at() checks

On Tue, Dec 9, 2015 at 17:26:56, Catalin Marinas
<catalin.marinas@....com> wrote:
>
> Currently the BUG_ON() checks do not give enough information about the PTEs being set. This patch changes BUG_ON to WARN_ONCE and dumps the values of the old and new PTEs.

This change broke building the mantis driver:

In file included from ./arch/arm64/include/asm/io.h:30:0,
                 from drivers/media/pci/mantis/mantis_i2c.c:21:
./arch/arm64/include/asm/pgtable.h: In function ‘set_pte_at’:
./arch/arm64/include/asm/pgtable.h:281:3: error: implicit declaration
of function ‘BUILD_BUG_ON_INVALID’
[-Werror=implicit-function-declaration]
   VM_WARN_ONCE(!pte_young(pte),
   ^

Thanks,
Andrew Pinski

>
> Signed-off-by: Catalin Marinas <catalin.marinas@....com>
> Cc: Will Deacon <will.deacon@....com>
> ---
>   arch/arm64/include/asm/pgtable.h | 11 +++++++----
>   1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/include/asm/pgtable.h
> b/arch/arm64/include/asm/pgtable.h
> index 7e074f93f383..002dc61a4dff 100644
> --- a/arch/arm64/include/asm/pgtable.h
> +++ b/arch/arm64/include/asm/pgtable.h
> @@ -276,10 +276,13 @@ static inline void set_pte_at(struct mm_struct *mm, unsigned long addr,
>          * hardware updates of the pte (ptep_set_access_flags safely changes
>          * valid ptes without going through an invalid entry).
>          */
> -       if (IS_ENABLED(CONFIG_DEBUG_VM) && IS_ENABLED(CONFIG_ARM64_HW_AFDBM) &&
> -           pte_valid(*ptep)) {
> -               BUG_ON(!pte_young(pte));
> -               BUG_ON(pte_write(*ptep) && !pte_dirty(pte));
> +       if (IS_ENABLED(CONFIG_ARM64_HW_AFDBM) && pte_valid(*ptep)) {
> +               VM_WARN_ONCE(!pte_young(pte),
> +                            "%s: racy access flag clearing: %016llx -> %016llx",
> +                            __func__, pte_val(*ptep), pte_val(pte));
> +               VM_WARN_ONCE(pte_write(*ptep) && !pte_dirty(pte),
> +                            "%s: racy dirty state clearing: %016llx -> %016llx",
> +                            __func__, pte_val(*ptep), pte_val(pte));
>         }
>
>         set_pte(ptep, pte);
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives