lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 17 Dec 2015 10:41:17 +0800 From: "Wu, Songjun" <songjun.wu@...el.com> To: Mark Brown <broonie@...nel.org> CC: <nicolas.ferre@...el.com>, <linux-arm-kernel@...ts.infradead.org>, Liam Girdwood <lgirdwood@...il.com>, Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, <linux-kernel@...r.kernel.org>, <alsa-devel@...a-project.org> Subject: Re: [PATCH 1/2] ASoC: atmel-pdmic: add the Pulse Density Modulation Interface Controller On 12/16/2015 20:27, Mark Brown wrote: > On Mon, Dec 14, 2015 at 04:15:39PM +0800, Songjun Wu wrote: > >> Add driver for the Pulse Density Modulation Interface >> Controller. It comes with digitallly controlled gain, >> a High-Pass and a SINCC filter. > > This looks basically OK but there's a *lot* of weird coding style issues > in here. It's really all that, nothing too serious that I noticed - > I've pointed out some of the patterns below not every individual issue. > >> + for (i = 0; i < ARRAY_SIZE(mic_gain_table); i++) { >> + if ((mic_gain_table[i].dgain == dgain_val) >> + && (mic_gain_table[i].scale == scale_val)) >> + ucontrol->value.integer.value[0] = i; >> + } > > This indentation is really weird, why is the && aligned with the if? > Accept. >> + snd_soc_update_bits(codec, PDMIC_DSPR1, >> + PDMIC_DSPR1_OFFSET_MASK, >> + (u32)(dd->pdata->mic_offset << PDMIC_DSPR1_OFFSET_SHIFT)); > > These are weird too, I'd expect the second line to be part of the first. > >> +static struct regmap *atmel_pdmic_codec_get_remap(struct device *dev) >> +{ >> + return dev_get_regmap(dev, NULL); >> +} > > This is (or should be) the default in the core. > You are right. The core has initialized the regmap in function snd_soc_component_add_unlocked. This function can be removed. Thank you. >> + if ((fs < rate_min) || (fs > rate_max)) { >> + dev_err(codec->dev, >> + "sample rate is %dHz, min rate is %dHz, max rate is %dHz\n", >> + fs, rate_min, rate_max); > > This too, alignment after the (. > Accept. >> + if (bits == 16) >> + dspr0_val = (PDMIC_DSPR0_SIZE_16_BITS >> + << PDMIC_DSPR0_SIZE_SHIFT); >> + else if (bits == 32) >> + dspr0_val = (PDMIC_DSPR0_SIZE_32_BITS >> + << PDMIC_DSPR0_SIZE_SHIFT); >> + else >> + return -EINVAL; > > This looks like it should be a switch statement. > Accept. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists