linux-kernel - Re: [PATCH v3 2/4] ARM: bcm2835: add rpi power domain driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87zix9rjr5.fsf@eliezer.anholt.net>
Date:	Wed, 16 Dec 2015 16:39:26 -0800
From:	Eric Anholt <eric@...olt.net>
To:	Ulf Hansson <ulf.hansson@...aro.org>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>
Cc:	Sebastian Reichel <sre@...g0.de>,
	Mark Rutland <mark.rutland@....com>,
	"devicetree\@vger.kernel.org" <devicetree@...r.kernel.org>,
	Florian Fainelli <f.fainelli@...il.com>,
	Alexander Aring <alex.aring@...il.com>,
	Pawel Moll <pawel.moll@....com>,
	Stephen Warren <swarren@...dotorg.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"linux-pm\@vger.kernel.org" <linux-pm@...r.kernel.org>,
	Lee Jones <lee@...nel.org>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
	Kevin Hilman <khilman@...nel.org>,
	Rob Herring <robh+dt@...nel.org>,
	linux-rpi-kernel@...ts.infradead.org,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	"linux-arm-kernel\@lists.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v3 2/4] ARM: bcm2835: add rpi power domain driver

Ulf Hansson <ulf.hansson@...aro.org> writes:

> On 16 December 2015 at 02:27, Krzysztof Kozlowski
> <k.kozlowski@...sung.com> wrote:
>> 2015-12-16 10:11 GMT+09:00 Sebastian Reichel <sre@...g0.de>:
>>> Hi,
>>>
>>> On Tue, Dec 15, 2015 at 04:53:31PM -0800, Eric Anholt wrote:
>>>> >> There are 6 power domain drivers in
>>>> >> arch/arm, 3 in drivers/clk, and 3 in drivers/soc.
>>>> >
>>>> > If we ever have to support a different architecture which happens to use
>>>> > a similar power domain, then we want it to be in a location which makes
>>>> > it easy for sharing it in the first place. As it stands today, it does
>>>> > not seem useful to me to have this code in arch/arm/mach-bcm/ at all.
>>>> >
>>>> > Maybe there is room from a drivers/power/domains/ of some kind?
>>>
>>> I like the idea, but let's include generic power domain maintainers
>>> in this discussion, as I suggested here (I got a power domain driver
>>> patch for drivers/power just a few days ago):
>>>
>>> https://lkml.org/lkml/2015/12/15/815
>>>
>>> Also somebody would have to step up to maintain that directory.
>>
>> This could go into drivers/soc. We put there a lot of mach-specific
>> stuff which we want to make a little more generic (like generic enough
>> multiplatform, multiarchitecture etc). Rockchip has its own power
>> domains there. Dove and Mediatek seem as well but I am not sure. Some
>> other architectures keep this still in arm/mach (exynos, ux500, zx,
>> imx, s34c64xx, shmobile) but this looks more of like a legacy choice.
>
> Agree, drivers/soc is good.

OK, I've resent with a move to drivers/soc/bcm/.

Download attachment "signature.asc" of type "application/pgp-signature" (819 bytes)