lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 17 Dec 2015 15:37:32 +0800 From: Baolin Wang <baolin.wang@...aro.org> To: Milan Broz <gmazyland@...il.com> Cc: Jens Axboe <axboe@...nel.dk>, Alasdair G Kergon <agk@...hat.com>, Mike Snitzer <snitzer@...hat.com>, dm-devel@...hat.com, neilb@...e.com, dan.j.williams@...el.com, martin.petersen@...cle.com, sagig@...lanox.com, Kent Overstreet <kent.overstreet@...il.com>, keith.busch@...el.com, tj@...nel.org, Mark Brown <broonie@...nel.org>, Arnd Bergmann <arnd@...db.de>, linux-block@...r.kernel.org, linux-raid@...r.kernel.org, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v2 0/2] Introduce the bulk IV mode for improving the crypto engine efficiency Hi Milan, On 16 December 2015 at 16:08, Milan Broz <gmazyland@...il.com> wrote: > On 12/16/2015 04:18 AM, Baolin Wang wrote: >> From the dm-crypt performance report, we found it shows low efficiency >> with crypto engine for some mode (like ecb or xts mode). Because in dm >> crypt, it will map the IO data buffer with scatterlist, and send the >> scatterlist of one bio to the encryption engine, if send more scatterlists >> with bigger size at one time, that helps the engine palys best performance, >> which means a high encryption speed. >> >> But now the dm-crypt only map one segment (always one sector) of one bio >> with one scatterlist to the crypto engine at one time. which is more >> time-consuming and ineffective for the crypto engine. Especially for some >> modes which don't need different IV for each sector, we can map the whole >> bio with multiple scatterlists to improve the engine performance. >> >> But this optimization is not support some ciphers and IV modes which should >> do sector by sector and need different IV for each sector. >> >> Change since v1: >> - Introduce one different IV mode. >> - Change the conditions for bulk mode. > > I tried the patchset on 32bit Intel VM and kernel immediately OOPsed (just tried aes-ecb)... > I've checked the code and I guess some macros I used with different definitions on different arch. Could you please try the new patchset with some optimization on your platform? It can work well on my arm board. Thanks. -- Baolin.wang Best Regards -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists