linux-kernel - Re: [PATCH] PM / sleep: define inline functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 16 Dec 2015 16:41:37 -0800
From:	Eric Anholt <eric@...olt.net>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Pavel Machek <pavel@....cz>, Len Brown <len.brown@...el.com>
Cc:	linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Subject: Re: [PATCH] PM / sleep: define inline functions

Sudip Mukherjee <sudipm.mukherjee@...il.com> writes:

> If CONFIG_PM_SLEEP is not defined then the functions are defined as
> NULL. And as a result we are getting build failure with
> alpha allmodconfig with the error:
>
> drivers/gpu/drm/vc4/vc4_v3d.c: In function 'vc4_v3d_set_power':
> include/linux/stddef.h:7:14: error: called object is not a function or function pointer
>  #define NULL ((void *)0)
>               ^
> include/linux/pm.h:776:30: note: in expansion of macro 'NULL'
>  #define pm_generic_poweroff  NULL
>                               ^
> drivers/gpu/drm/vc4/vc4_v3d.c:157:10: note: in expansion of macro 'pm_generic_poweroff'
>    return pm_generic_poweroff(&vc4->v3d->pdev->dev);
>           ^
> include/linux/stddef.h:7:14: error: called object is not a function or function pointer
>  #define NULL ((void *)0)
>               ^
> include/linux/pm.h:764:28: note: in expansion of macro 'NULL'
>  #define pm_generic_resume  NULL
>                             ^
> drivers/gpu/drm/vc4/vc4_v3d.c:159:10: note: in expansion of macro 'pm_generic_resume'
>    return pm_generic_resume(&vc4->v3d->pdev->dev);
>           ^
>
> Fixes: d5b1a78a772f ("drm/vc4: Add support for drawing 3D frames.")
> Cc: Eric Anholt <eric@...olt.net>
> Signed-off-by: Sudip Mukherjee <sudip@...torindia.org>

I'm happy with this solution, and would also be willing to just depend
on the config option as well.  Whatever people prefer.

Download attachment "signature.asc" of type "application/pgp-signature" (819 bytes)