linux-kernel - Re: [RFC PATCH] lpfc: Add lockdep assertions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56727974.3040603@sandisk.com>
Date:	Thu, 17 Dec 2015 09:59:32 +0100
From:	Bart Van Assche <bart.vanassche@...disk.com>
To:	Johannes Thumshirn <jthumshirn@...e.de>,
	James Smart <james.smart@...gotech.com>
CC:	"James E.J. Bottomley" <JBottomley@...n.com>,
	Dick Kennedy <dick.kennedy@...gotech.com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	<linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH] lpfc: Add lockdep assertions

On 12/17/2015 09:49 AM, Johannes Thumshirn wrote:
> On Wed, Dec 16, 2015 at 03:22:50PM -0800, James Smart wrote:
>> Johannes,
>>
>> Thank you for the time and effort on the patch. At this time, as it doesn't
>> functionally change anything, I did not include the patch. I will consider
>> it if we see additional issues it can help resolve.
>
> As I already said in the patch mail, I'm not sure if it is of intereset for
> upstream, but can actually be quite handy to find something if it goes wrong.

I'd like to see this patch being merged upstream. lockdep_assert_held() 
statements are checked at runtime when using a debug kernel, which is 
not the case for comments that document locking conventions.

Thanks,

Bart.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/