linux-kernel - RE: [PATCH] mfd: da9063: Allow modular build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6ED8E3B22081A4459DAC7699F3695FB70173D28E2E@SW-EX-MBX02.diasemi.com>
Date:	Thu, 17 Dec 2015 13:26:19 +0000
From:	"Opensource [Steve Twiss]" <stwiss.opensource@...semi.com>
To:	Lee Jones <lee.jones@...aro.org>,
	Geert Uytterhoeven <geert+renesas@...der.be>
CC:	Support Opensource <Support.Opensource@...semi.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] mfd: da9063: Allow modular build

On 08 December 2015 13:56, Lee Jones wrote:

> To: Geert Uytterhoeven
> Subject: Re: [PATCH] mfd: da9063: Allow modular build
> 
> On Mon, 07 Dec 2015, Geert Uytterhoeven wrote:
> 
> > Allow support for the DA9063 PMIC to be modular, cfr. DA9062, which
> > allows to decrease size of multi-platform kernels (e.g.
> > multi_v7_defconfig).
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> > ---
> >  drivers/mfd/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> The DA9063 driver appears to contain all module code.  In fact, I'm
> surprised that it wasn't enabled for tristate in the first place.
> 
> In any case, it would be good to get a Reviewed/Acked-by from one of
> the Dialog guys.

Yes. 
Without this we cannot load any of the sub-devices as modules for the DA9063.
Sorry this has taken so long for me to look at.

Acked-by: Steve Twiss <stwiss.opensource@...semi.com>

Regards,
Steve

> 
> > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> > index 4d92df6ef9fe92ac..527ee7168617c933 100644
> > --- a/drivers/mfd/Kconfig
> > +++ b/drivers/mfd/Kconfig
> > @@ -211,7 +211,7 @@ config MFD_DA9062
> >  	  of the device.
> >
> >  config MFD_DA9063
> > -	bool "Dialog Semiconductor DA9063 PMIC Support"
> > +	tristate "Dialog Semiconductor DA9063 PMIC Support"
> >  	select MFD_CORE
> >  	select REGMAP_I2C
> >  	select REGMAP_IRQ
> 
> --
> Lee Jones
> Linaro STMicroelectronics Landing Team Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog