linux-kernel - Re: [PATCH] drivers/tty/serial: delete unused MODULE_DEVICE_TABLE from atmel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5672D82A.1090401@atmel.com>
Date:	Thu, 17 Dec 2015 16:43:38 +0100
From:	Nicolas Ferre <nicolas.ferre@...el.com>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>,
	<linux-kernel@...r.kernel.org>, <linux-serial@...r.kernel.org>,
	"Greg Kroah-Hartman" <gregkh@...uxfoundation.org>
CC:	Jiri Slaby <jslaby@...e.com>,
	Sudip Mukherjee <sudip@...torindia.org>
Subject: Re: [PATCH] drivers/tty/serial: delete unused MODULE_DEVICE_TABLE
 from atmel_serial.c

Le 17/12/2015 16:05, Paul Gortmaker a écrit :
> In commit c39dfebc7798956fd2140ae6321786ff35da30c3 ("drivers/tty/serial:
> make serial/atmel_serial.c explicitly non-modular") we removed the code
> relating to modular support since it currently only supports built in.
> 
> However, when redoing my build coverage for mips allmodconfig, which
> sets CONFIG_OF, I noticed a remaining line that needs to be removed,
> else we will get a build failure for an undefined module macro.
> 
> Unfortunately this didn't appear for any of the other arch I tested
> more frequently, such as ARM.
> 
> Since MODULE_DEVICE_TABLE is a no-op for non-modular code, we can just
> remove the offending line.
> 
> Fixes: c39dfebc7798 ("drivers/tty/serial: make serial/atmel_serial.c explicitly non-modular")
> Cc: Nicolas Ferre <nicolas.ferre@...el.com>

Absolutely:
Acked-by: Nicolas Ferre <nicolas.ferre@...el.com>

Thank you Sudip and Paul.

Bye,


> Cc: Jiri Slaby <jslaby@...e.com>
> Cc: linux-serial@...r.kernel.org
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Sudip Mukherjee <sudip@...torindia.org>
> Reported-by: Sudip Mukherjee <sudip@...torindia.org>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
> ---
>  drivers/tty/serial/atmel_serial.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
> index 50e785a0ea73..1c0884d8ef32 100644
> --- a/drivers/tty/serial/atmel_serial.c
> +++ b/drivers/tty/serial/atmel_serial.c
> @@ -188,8 +188,6 @@ static const struct of_device_id atmel_serial_dt_ids[] = {
>  	{ .compatible = "atmel,at91sam9260-usart" },
>  	{ /* sentinel */ }
>  };
> -
> -MODULE_DEVICE_TABLE(of, atmel_serial_dt_ids);
>  #endif
>  
>  static inline struct atmel_uart_port *
> 


-- 
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/