linux-kernel - [PATCH v3] cgroups: move cpuset specific checks from generic code to cpuset_can

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20151217155645.GA31625@amt.cnet>
Date:	Thu, 17 Dec 2015 13:56:46 -0200
From:	Marcelo Tosatti <mtosatti@...hat.com>
To:	linux-kernel@...r.kernel.org, Tejun Heo <tj@...nel.org>,
	Luiz Capitulino <lcapitulino@...hat.com>
Cc:	Chao Peng <chao.p.peng@...ux.intel.com>,
	Vikas Shivappa <vikas.shivappa@...el.com>
Subject: [PATCH v3] cgroups: move cpuset specific checks from generic code to
 cpuset_can_attach


Move PF_NO_SETAFFINITY check to cpuset cgroups, where it belongs.
This makes it possible to attach PF_NO_SETAFFINITY to Intel CAT cgroups.

Reported-by: Luiz Capitulino <lcapitulino@...hat.com>
Signed-off-by: Marcelo Tosatti <mtosatti@...hat.com>

v2: "PF_NO_SETAFFINITY check" -> "PF_NO_SETAFFINITY and kthreadd_task
checks"
v3: keep kthreadd_task check for all cgroup controllers

diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 470f653..66a1c32 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -2740,11 +2740,10 @@ static ssize_t __cgroup_procs_write(struct kernfs_open_file *of, char *buf,
 		tsk = tsk->group_leader;
 
 	/*
-	 * Workqueue threads may acquire PF_NO_SETAFFINITY and become
-	 * trapped in a cpuset, or RT worker may be born in a cgroup
-	 * with no rt_runtime allocated.  Just say no.
+	 * RT worker may be born in a cgroup with no
+	 * rt_runtime allocated.  Just say no.
 	 */
-	if (tsk == kthreadd_task || (tsk->flags & PF_NO_SETAFFINITY)) {
+	if (tsk == kthreadd_task) {
 		ret = -EINVAL;
 		goto out_unlock_rcu;
 	}
diff --git a/kernel/cpuset.c b/kernel/cpuset.c
index 02a8ea5..67756bc 100644
--- a/kernel/cpuset.c
+++ b/kernel/cpuset.c
@@ -53,6 +53,7 @@
 #include <linux/time.h>
 #include <linux/backing-dev.h>
 #include <linux/sort.h>
+#include <linux/kthread.h>
 
 #include <asm/uaccess.h>
 #include <linux/atomic.h>
@@ -1449,6 +1450,14 @@ static int cpuset_can_attach(struct cgroup_taskset *tset)
 		goto out_unlock;
 
 	cgroup_taskset_for_each(task, css, tset) {
+		/*
+		 * Workqueue threads may acquire PF_NO_SETAFFINITY and
+		 * become trapped in a cpuset.
+		 */
+		if (task->flags & PF_NO_SETAFFINITY) {
+			ret = -EINVAL;
+			goto out_unlock;
+		}
 		ret = task_can_attach(task, cs->cpus_allowed);
 		if (ret)
 			goto out_unlock;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/