linux-kernel - Re: [PATCH 17/25] perf stat report: Move csv_sep initialization before report command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 17 Dec 2015 20:46:29 +0100
From:	Jiri Olsa <jolsa@...hat.com>
To:	Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:	Jiri Olsa <jolsa@...nel.org>, lkml <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>,
	Ingo Molnar <mingo@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	"Liang, Kan" <kan.liang@...el.com>
Subject: Re: [PATCH 17/25] perf stat report: Move csv_sep initialization
 before report command

On Thu, Dec 17, 2015 at 03:57:07PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Nov 05, 2015 at 03:41:01PM +0100, Jiri Olsa escreveu:
> > So we have csv_sep properly initialized before
> > report command leg.
> 
> I moved this to before "perf stat report: Process stat and stat round
> events" so that what you wrote above makes sense, i.e. after this patch
> nothing is produced by 'perf stat report' and right after the stat and
> stat round one is applied I get:
> 
>   [acme@...andy linux]$ perf stat report
> 
>    Performance counter stats for '/home/acme/bin/perf stat record usleep 1':
> 
>           0.411636      task-clock (msec)         #    0.571 CPUs utilized          
>                  2      context-switches          #    0.005 M/sec                  
>                  0      cpu-migrations            #    0.000 K/sec                  
>                149      page-faults               #    0.362 M/sec                  
>          1,291,807      cycles                    #    3.138 GHz                    
>            959,632      stalled-cycles-frontend   #   74.29% frontend cycles idle   
>            703,170      stalled-cycles-backend    #   54.43% backend  cycles idle   
>            757,538      instructions              #    0.59  insns per cycle        
>                                                   #    1.27  stalled cycles per insn
>            133,293      branches                  #  323.813 M/sec                  
>      <not counted>      branch-misses              (0.00%)
> 
>        0.000720394 seconds time elapsed
> 
>   [acme@...andy linux]$ 
> 
> And not this ugly thing:
> 
>   [acme@...andy linux]$ perf stat report
> 
>    Performance counter stats for '/home/acme/bin/perf stat record usleep 1':
> 
>           0.411636(null)    (null)task-clock (msec)         #    0.571 CPUs utilized          
>                  2(null)    (null)context-switches          #    0.005 M/sec                  
>                  0(null)    (null)cpu-migrations            #    0.000 K/sec                  
>                149(null)    (null)page-faults               #    0.362 M/sec                  
>          1,291,807(null)    (null)cycles                    #    3.138 GHz                    
>            959,632(null)    (null)stalled-cycles-frontend   #   74.29% frontend cycles idle   
>            703,170(null)    (null)stalled-cycles-backend    #   54.43% backend  cycles idle   
>            757,538(null)    (null)instructions              #    0.59  insns per cycle        
>                                                   #    1.27  stalled cycles per insn
>            133,293(null)    (null)branches                  #  323.813 M/sec                  
>      <not counted>(null)    (null)branch-misses              (0.00%)
> 
>        0.000720394 seconds time elapsed
> 
>   [acme@...andy linux]$

sounds good, thanks

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/