linux-kernel - Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <yw1x37v0df86.fsf@unicorn.mansr.com>
Date:	Thu, 17 Dec 2015 19:53:13 +0000
From:	Måns Rullgård <mans@...sr.com>
To:	Julian Margetson <runaway@...dw.ms>
Cc:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Tejun Heo <tj@...nel.org>, linux-ide@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

Julian Margetson <runaway@...dw.ms> writes:

> On 12/17/2015 2:51 PM, Måns Rullgård wrote:
>> Julian Margetson <runaway@...dw.ms> writes:
>>
>>> On 12/17/2015 1:59 PM, Måns Rullgård wrote:
>>>> Julian Margetson <runaway@...dw.ms> writes:
>>>>
>>>>> I have been running my machine mostly configured for pciex1  thus with
>>>>> the sata_dwc disabled.
>>>>> The changes to sata_dwc-460ex do cause an oops.
>>>>> I will try to give more detailed info over this weekend .
>>>> The driver as is upstream would do that since it unconditionally
>>>> dereferences a null pointer in the probe function.  My patch fixes that
>>>> as a side-effect.
>>>>
>>> patching file drivers/ata/Kconfig
>>>
>>> Hunk #1 FAILED at 296.
>> [...]
>>
>>> root@...ian-VirtualBox:/usr/src/linux-3.18.25#
>> The patch is against 4.4-rc5.
>>
>  CC      drivers/ata/sata_dwc_460ex.o
>
> drivers/ata/sata_dwc_460ex.c:198:15: error: variable â€˜sata_dwc_dma_dwsâ€™ has initializer but incomplete type
>
>  static struct dw_dma_slave sata_dwc_dma_dws = {
>                ^

It builds, albeit with an unrelated warning, using the attached config.
Maybe there's a missing config dependency somewhere.

-- 
Måns Rullgård

View attachment ".config" of type "text/plain" (60936 bytes)