linux-kernel - Re: [RESEND][PATCH v2] dmaengine: bcm2835: Add slave dma support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151218060526.GW1854@localhost>
Date:	Fri, 18 Dec 2015 11:35:26 +0530
From:	Vinod Koul <vinod.koul@...el.com>
To:	Martin Sperl <kernel@...tin.sperl.org>
Cc:	dmaengine@...r.kernel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-rpi-kernel <linux-rpi-kernel@...ts.infradead.org>,
	Noralf Trønnes <noralf@...nnes.org>,
	jonathan@...pberrypi.org, dan.j.williams@...el.com,
	Eric Anholt <eric@...olt.net>,
	Stephen Warren <swarren@...dotorg.org>,
	Lee Jones <lee@...nel.org>
Subject: Re: [RESEND][PATCH v2] dmaengine: bcm2835: Add slave dma support

On Thu, Dec 17, 2015 at 07:11:48PM +0100, Martin Sperl wrote:

> +
> +			/* Setup addresses */
> +			if (d->dir == DMA_DEV_TO_MEM) {
> +				control_block->info = BCM2835_DMA_D_INC |
> +						      BCM2835_DMA_D_WIDTH |
> +						      BCM2835_DMA_S_DREQ;
> +				control_block->src = dev_addr;
> +				control_block->dst = addr + (dma_addr_t)j;
> +			} else {
> +				control_block->info = BCM2835_DMA_S_INC |
> +						      BCM2835_DMA_S_WIDTH |
> +						      BCM2835_DMA_D_DREQ;
> +				control_block->src = addr + (dma_addr_t)j;
> +				control_block->dst = dev_addr;
> +			}
> +
> +			/* Common part */
> +			control_block->info |=
> +				BCM2835_DMA_WAITS(BCM2835_DMA_WAIT_CYCLES);
> +			control_block->info |= BCM2835_DMA_WAIT_RESP;
> +
> +			/* Enable */
> +			if (i == sg_len - 1 && len - j <= max_size)
> +				control_block->info |= BCM2835_DMA_INT_EN;
> +
> +			/* Setup synchronization */
> +			if (sync_type)
> +				control_block->info |= sync_type;
> +
> +			/* Setup DREQ channel */
> +			if (c->dreq)
> +				control_block->info |=
> +					BCM2835_DMA_PER_MAP(c->dreq);
> +
> +			/* Length of a frame */
> +			control_block->length = min(len - j, max_size);
> +			d->size += control_block->length;
> +
> +			if (i < sg_len - 1 || len - j > max_size) {
> +				/* Next block is the next frame. */
> +				control_block->next =
> +					d->control_block_base_phys +
> +					sizeof(struct bcm2835_dma_cb) *
> +					(i + split_cnt + 1);
> +			} else {
> +				/* Next block is empty. */
> +				control_block->next = 0;
> +			}
> +
> +			if (len - j > max_size)
> +				split_cnt++;

Most of this part is common with the cyclic and seems copy paste. Can we
use common routine to do common work please

-- 
~Vinod
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/