linux-kernel - Re: [PATCH 2/2] pci: Update VPD size with correct length

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <567410D3.7030909@suse.de>
Date:	Fri, 18 Dec 2015 14:57:39 +0100
From:	Hannes Reinecke <hare@...e.de>
To:	Alexander Duyck <alexander.duyck@...il.com>
Cc:	Bjorn Helgaas <bhelgaas@...gle.com>,
	Michal Kubecek <mkubecek@...e.com>,
	"Shane M. Seymour" <shane.seymour@....com>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Bjorn Helgaas <helgaas@...nel.org>
Subject: Re: [PATCH 2/2] pci: Update VPD size with correct length

On 12/18/2015 02:49 PM, Alexander Duyck wrote:
> On Fri, Dec 18, 2015 at 12:35 AM, Hannes Reinecke <hare@...e.de> wrote:
>> PCI-2.2 VPD entries have a maximum size of 32k, but might actually
>> be smaller than that. To figure out the actual size one has to read
>> the VPD area until the 'end marker' is reached.
>> Trying to read VPD data beyond that marker results in 'interesting'
>> effects, from simple read errors to crashing the card. And to make
>> matters worse not every PCI card implements this properly, leaving
>> us with no 'end' marker or even completely invalid data.
>> This path modifies the size of the VPD attribute to the available
>> size, or set it to '0' if no valid data could be read.
>
> This isn't what I had in mind.  There is no need to add an f0 version
> of the size function.  The size for all functions other than function
> 0 when the F0 flag is set is 0.  We aren't going to be reading their
> VPD, we only read the VPD region of function 0.
>
Ah. (I'm a bit confused about the proposed action for VPD other than 
function 0).
So the idea here is to _disallow_ access to VPDs from functions 
other than '0' unless these functions have different PCI IDs?

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		               zSeries & Storage
hare@...e.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/