linux-kernel - Re: [PATCH] hwmon: sht15 needs CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5674324E.6050908@roeck-us.net>
Date:	Fri, 18 Dec 2015 08:20:30 -0800
From:	Guenter Roeck <linux@...ck-us.net>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	yalin wang <yalin.wang2010@...il.com>,
	Jean Delvare <jdelvare@...e.com>, lm-sensors@...sensors.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] hwmon: sht15 needs CONFIG_BITREVERSE

On 12/18/2015 06:52 AM, Arnd Bergmann wrote:
> If CONFIG_BITREVERSE is not built-in, the sht15 driver fails to link:
>
> drivers/built-in.o: In function `sht15_crc8':
> drivers/hwmon/sht15.c:195: undefined reference to `byte_rev_table'
>
> This adds a Kconfig 'select' statement, like all other users of
> bitrev.h have it.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: 33836ee98533 ("hwmon:change sht15_reverse()")

Good catch. Applied.

Thanks,
Guenter

>
> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> index 4a6e7c217329..60fb80bd353d 100644
> --- a/drivers/hwmon/Kconfig
> +++ b/drivers/hwmon/Kconfig
> @@ -1207,6 +1207,7 @@ config SENSORS_PWM_FAN
>   config SENSORS_SHT15
>   	tristate "Sensiron humidity and temperature sensors. SHT15 and compat."
>   	depends on GPIOLIB || COMPILE_TEST
> +	select BITREVERSE
>   	help
>   	  If you say yes here you get support for the Sensiron SHT10, SHT11,
>   	  SHT15, SHT71, SHT75 humidity and temperature sensors.
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/