[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <567435D5.2040605@laposte.net>
Date: Fri, 18 Dec 2015 17:35:33 +0100
From: Sebastian Frias <sf84@...oste.net>
To: Peter Hurley <peter@...leysoftware.com>
CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Måns Rullgård
<mans@...sr.com>, linux-serial@...r.kernel.org,
LKML <linux-kernel@...r.kernel.org>, Mason <slash.tmp@...e.fr>,
Jon Anders Haugum <jonah@...gav.ntnu.no>
Subject: Re: [PATCH v2] use callbacks to access UART_DLL/UART_DLM
On 12/18/2015 05:34 PM, Peter Hurley wrote:
> On 12/18/2015 08:27 AM, Sebastian Frias wrote:
>> On 12/18/2015 05:06 PM, Peter Hurley wrote:
>>>> - unsigned char old_dll, old_dlm, old_lcr;
>>>> + unsigned char old_lcr;
>>>> unsigned int id;
>>>> + unsigned int old_dl;
>>>
>>> unsigned int id, old_dl;
>>
>> Ok, thanks for your comments.
>> By the way, should I just do:
>>
>> - unsigned char old_dll, old_dlm, old_lcr;
>> + unsigned char old_lcr, old_dl;
>>
>> ?
>
> The divisor is a 16-bit value.
>
You are right, I was too eager to "reduce the amount of lines that
change"...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists