linux-kernel - Re: [PATCH v3 3/7] tpm_tis: Do not fall back to a hardcoded address for TPM2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151218165127.GC7354@obsidianresearch.com>
Date:	Fri, 18 Dec 2015 09:51:27 -0700
From:	Jason Gunthorpe <jgunthorpe@...idianresearch.com>
To:	Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
Cc:	g@...el.com, tpmdd-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org,
	Martin Wilck <Martin.Wilck@...fujitsu.com>,
	Peter Huewe <peterhuewe@....de>,
	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
Subject: Re: [PATCH v3 3/7] tpm_tis: Do not fall back to a hardcoded address
 for TPM2

On Fri, Dec 18, 2015 at 11:34:32AM +0200, Jarkko Sakkinen wrote:
> > +	st = acpi_get_table(ACPI_SIG_TPM2, 1,
> > +			    (struct acpi_table_header **) &tbl);
> > +	if (ACPI_FAILURE(st) || tbl->header.length < sizeof(*tbl)) {
> > +		dev_err(&acpi_dev->dev,
> > +			FW_BUG "failed to get TPM2 ACPI table\n");
> > +		return -EINVAL;
> > +	}
> > +
> > +	if (tbl->start_method != ACPI_TPM2_MEMORY_MAPPED)
> >  		return -ENODEV;
> >  
> >  	INIT_LIST_HEAD(&resources);
> > @@ -996,6 +978,12 @@ static int tpm_tis_acpi_init(struct acpi_device *acpi_dev)
> >  
> >  	acpi_dev_free_resource_list(&resources);
> >  
> > +	if (tpm_info.start == 0 && tpm_info.len == 0) {
> > +		dev_err(&acpi_dev->dev,
> > +			FW_BUG "TPM2 ACPI table does not define a memory resource\n");
> > +		return -EINVAL;
> > +	}
> > +
> 
> I guess this the only relevant change in this patch? You should propose
> removal of is_fifo() as a separate patch if that makes sense. This patch
> is now doing orthogonal things.

No, the return code changes are relevant too, and are why is_fifo was
best un-inlined.

The patch is fixing all the ACPI data validatation in one go, not just
the resource range, the description notes this.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/