lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 17 Dec 2015 18:46:44 -0800 From: Davidlohr Bueso <dave@...olabs.net> To: Paul Gortmaker <paul.gortmaker@...driver.com> Cc: linux-kernel@...r.kernel.org, Nadia Yvette Chambers <nyc@...omorphy.com>, Alexander Viro <viro@...iv.linux.org.uk>, Andrew Morton <akpm@...ux-foundation.org>, Naoya Horiguchi <n-horiguchi@...jp.nec.com>, Mike Kravetz <mike.kravetz@...cle.com>, David Rientjes <rientjes@...gle.com>, Hillf Danton <hillf.zj@...baba-inc.com>, linux-mm@...ck.org, linux-fsdevel@...r.kernel.org Subject: Re: [PATCH 1/8] hugetlb: make mm and fs code explicitly non-modular On Thu, 17 Dec 2015, Paul Gortmaker wrote: >The Kconfig currently controlling compilation of this code is: > >config HUGETLBFS > bool "HugeTLB file system support" > >...meaning that it currently is not being built as a module by anyone. > >Lets remove the modular code that is essentially orphaned, so that >when reading the driver there is no doubt it is builtin-only. > >Since module_init translates to device_initcall in the non-modular >case, the init ordering gets moved to earlier levels when we use the >more appropriate initcalls here. > >Originally I had the fs part and the mm part as separate commits, >just by happenstance of the nature of how I detected these >non-modular use cases. But that can possibly introduce regressions >if the patch merge ordering puts the fs part 1st -- as the 0-day >testing reported a splat at mount time. > >Investigating with "initcall_debug" showed that the delta was >init_hugetlbfs_fs being called _before_ hugetlb_init instead of >after. So both the fs change and the mm change are here together. > >In addition, it worked before due to luck of link order, since they >were both in the same initcall category. So we now have the fs >part using fs_initcall, and the mm part using subsys_initcall, >which puts it one bucket earlier. It now passes the basic sanity >test that failed in earlier 0-day testing. > >We delete the MODULE_LICENSE tag and capture that information at the >top of the file alongside author comments, etc. > >We don't replace module.h with init.h since the file already has that. >Also note that MODULE_ALIAS is a no-op for non-modular code. > >Cc: Nadia Yvette Chambers <nyc@...omorphy.com> >Cc: Alexander Viro <viro@...iv.linux.org.uk> >Cc: Andrew Morton <akpm@...ux-foundation.org> >Cc: Naoya Horiguchi <n-horiguchi@...jp.nec.com> >Cc: Mike Kravetz <mike.kravetz@...cle.com> >Cc: David Rientjes <rientjes@...gle.com> >Cc: Hillf Danton <hillf.zj@...baba-inc.com> >Cc: Davidlohr Bueso <dave@...olabs.net> >Cc: linux-mm@...ck.org >Cc: linux-fsdevel@...r.kernel.org >Reported-by: kernel test robot <ying.huang@...ux.intel.com> >Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com> Acked-by: Davidlohr Bueso <dave@...olabs.net> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists