| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <2005828.pC3KGx5clE@wuerfel> Date: Fri, 18 Dec 2015 22:09:12 +0100 From: Arnd Bergmann <arnd@...db.de> To: Kees Cook <keescook@...omium.org> Cc: Russell King <linux@....linux.org.uk>, linux-kernel@...r.kernel.org, Jeffy <jeffy.chen@...k-chips.com>, Simon Horman <horms+renesas@...ge.net.au>, Geert Uytterhoeven <geert+renesas@...der.be>, Laurent Pinchart <laurent.pinchart@...asonboard.com>, Magnus Damm <damm+renesas@...nsource.se>, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH] ARM: fix atags_to_fdt with stack-protector-strong On Friday 18 December 2015 13:04:59 Kees Cook wrote: > +ifeq ($(CONFIG_ARM_ATAG_DTB_COMPAT),y) > +CFLAGS_atags_to_fdt.o := -fno-stack-protector > +CFLAGS_fdt.o := -fno-stack-protector > +CFLAGS_fdt_ro.o := -fno-stack-protector > +CFLAGS_fdt_rw.o := -fno-stack-protector > +CFLAGS_fdt_wip.o := -fno-stack-protector > +endif I'm pretty sure you don't need the ifeq there, you can simply define those flags unconditionally. You can't just add -fno-stack-protector unconditionally, because that breaks building the kernel with toolchains that are older than stack-protector, so this should be CFLAGS_obj.o += $(call cc-option, -fno-stack-protector) Other than that, the patch looks ok. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists