linux-kernel - Re: [PATCH V3] Fix INT1 Recursion with unregistered breakpoints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1512191603300.28591@nanos>
Date:	Sat, 19 Dec 2015 16:05:00 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Jeff Merkey <linux.mdb@...il.com>
cc:	linux-kernel@...r.kernel.org, mingo@...hat.com, hpa@...or.com,
	x86@...nel.org, peterz@...radead.org, luto@...nel.org
Subject: Re: [PATCH V3] Fix INT1 Recursion with unregistered breakpoints

On Mon, 14 Dec 2015, Jeff Merkey wrote:
> +		/*
> +		* check if we got an execute breakpoint
> +		* from the dr7 register.  if we did, set
> +		* the resume flag to avoid int1 recursion.

Malformatted comment as any other comment you touched.

> +		*/
> +		if ((dr7 & (3 << ((i * 4) + 16))) == 0)
> +			args->regs->flags |= X86_EFLAGS_RF;

This still uses magic numbers instead of the proper defines. I asked
for that before.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/