linux-kernel - Re: [PATCH V7 24/24] perf tools: adding coresight etm PMU record capabilities

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151219172705.GC2437@debian>
Date:	Sat, 19 Dec 2015 18:27:05 +0100
From:	Rabin Vincent <rabin@....in>
To:	Mathieu Poirier <mathieu.poirier@...aro.org>
Cc:	gregkh@...uxfoundation.org, alexander.shishkin@...ux.intel.com,
	zhang.chunyan@...aro.org, mike.leach@....com, tor@...com,
	al.grant@....com, fainelli@...adcom.com,
	linux-arm-kernel@...ts.infradead.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>
Subject: Re: [PATCH V7 24/24] perf tools: adding coresight etm PMU record
 capabilities

On Fri, Dec 18, 2015 at 01:59:20PM -0700, Mathieu Poirier wrote:
> +struct auxtrace_record
> +*auxtrace_record__init(struct perf_evlist *evlist, int *err)
> +{
> +	struct perf_pmu	*cs_etm_pmu;
> +	struct perf_evsel *evsel;
> +	bool found_etm = false;
> +
> +	cs_etm_pmu = perf_pmu__find(CORESIGHT_ETM_PMU_NAME);
> +
> +	 if (evlist) {
> +		evlist__for_each(evlist, evsel) {
> +			if (cs_etm_pmu &&
> +			    evsel->attr.type == cs_etm_pmu->type)
> +				found_etm = true;
> +		}
> +	}
> +
> +	if (found_etm)
> +		return cs_etm_record_init(err);
> +
> +	*err = -EINVAL;

This should not set an error code when found_etm is false.  Otherwise
any attempt to uses perf record without a cs_etm event enabled errors
out.

> +	return NULL;
> +}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/