linux-kernel - Re: [PATCH V3] Fix INT1 Recursion with unregistered breakpoints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAO6TR8XQK-NNYSTbSuL_Y88TXEWPeqVBQF49LmrNwO4mkbn3Sg@mail.gmail.com>
Date:	Sat, 19 Dec 2015 16:12:43 -0700
From:	Jeff Merkey <linux.mdb@...il.com>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	linux-kernel@...r.kernel.org, mingo@...hat.com, hpa@...or.com,
	x86@...nel.org, peterz@...radead.org, luto@...nel.org
Subject: Re: [PATCH V3] Fix INT1 Recursion with unregistered breakpoints

I cleaned up the areas you identified and I am building and testing
the the patch
with the debugger test harness.  As soon as it passes the build completes and
it passes the test harness I will submit v4 of the patch.

Jeff


On 12/19/15, Thomas Gleixner <tglx@...utronix.de> wrote:
> On Mon, 14 Dec 2015, Jeff Merkey wrote:
>> +		/*
>> +		* check if we got an execute breakpoint
>> +		* from the dr7 register.  if we did, set
>> +		* the resume flag to avoid int1 recursion.
>
> Malformatted comment as any other comment you touched.
>
>> +		*/
>> +		if ((dr7 & (3 << ((i * 4) + 16))) == 0)
>> +			args->regs->flags |= X86_EFLAGS_RF;
>
> This still uses magic numbers instead of the proper defines. I asked
> for that before.
>
> Thanks,
>
> 	tglx
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/