linux-kernel - Re: Indent issus in kernel module development

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 19 Dec 2015 13:50:05 +0800
From:	chunguang qu <quchunguang@...il.com>
To:	Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org
Subject: Re: Indent issus in kernel module development

Yes, I just tried `scripts/Lindent` and it has the same problem.

I had compared the source of `Lindent` with `-linux` option of
`indent` long time ago, there's seems no major difference.
So i used `indent -linux <file>` above.

Thanks for your advice about `emace`, but `vi` is my only editor for
dozens of years.

2015-12-19 10:26 GMT+08:00 Randy Dunlap <rdunlap@...radead.org>:
> On 12/18/15 18:07, chunguang qu wrote:
>> `indent -linux` sometimes made my code totally a mess.
>> I know it most likely a bug of GNU INDENT. And this is not a bug report.
>> I only want to know other kernel developers how to deal with this problem.
>> Since GUN INDENT is recommend in kernel's CodingStyle, I think surely
>> someone here encounter this problem either.
>
> Huh?
>
> CodingStyle says:
>
>   Now, again, GNU indent has the same brain-dead settings that GNU emacs
>   has, which is why you need to give it a few command line options.
>
> It also says try using scripts/Lindent.  Have you tried it?
> It won't be perfect either, AFAI recall, but it might help.
>
> or you could try emacs (as indicated in CodingStyle).  Good luck with that.
>
>
>
>> CMD
>> LANG=C indent -linux
>>
>> FROM
>> http://paste.ubuntu.com/14093393/
>>
>> TO
>> http://paste.ubuntu.com/14093405/
>>
>> Thanks.
>
>
>
>
> --
> ~Randy



-- 
[Kevin Q (ChunGuang Qu)](mailto:quchunguang@...il.com) [public
key](http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x5B06DCA77BEF043B)
@sdu.edu.cn @gnu.org @mit.edu @grazestar.com @jolijolie.cn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/