linux-kernel - Re: [PATCH v4] of: fix declaration of of_io_request_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151219063914.GB14071@sudip-pc>
Date:	Sat, 19 Dec 2015 12:09:14 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Rob Herring <robh+dt@...nel.org>
Cc:	Frank Rowand <frowand.list@...il.com>,
	Grant Likely <grant.likely@...aro.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Daniel Lezcano <daniel.lezcano@...aro.org>
Subject: Re: [PATCH v4] of: fix declaration of of_io_request_and_map

On Thu, Dec 17, 2015 at 11:55:28AM -0600, Rob Herring wrote:
> On Tue, Dec 8, 2015 at 2:47 AM, Sudip Mukherjee
> <sudipm.mukherjee@...il.com> wrote:
> > We are having build failure with linux-next for sparc allmodconfig with
> > the error messages:
> >
> > drivers/built-in.o: In function `meson6_timer_init':
> > meson6_timer.c:(.init.text+0x5fe8): undefined reference to `of_io_request_and_map'
> > drivers/built-in.o: In function `mtk_timer_init':
> > mtk_timer.c:(.init.text+0x6af0): undefined reference to `of_io_request_and_map'
> > drivers/built-in.o: In function `asm9260_timer_init':
> > asm9260_timer.c:(.init.text+0x6c48): undefined reference to `of_io_request_and_map'
> >
> > CONFIG_OF is defined for sparc so it is expected that we have a
> > definition of of_io_request_and_map() but of/address.c is only compiled
> > if it is !SPARC. In other words, CONFIG_OF_ADDRESS is not defined for
> > sparc so we get the build failure.
> >
> > Fixes: e572f844ca66 ("clocksource/drivers/meson6: Add the COMPILE_TEST option")
> > Fixes: bec8c4617611 ("clocksource/drivers/mediatek: Add the COMPILE_TEST option")
> > Fixes: 4a373b45f94a ("clocksource/drivers/asm9260: Add the COMPILE_TEST option")
> > Cc: Daniel Lezcano <daniel.lezcano@...aro.org>
> > Signed-off-by: Sudip Mukherjee <sudip@...torindia.org>
> 
> Moved the include out of the ifdefs and applied, thanks.

Thanks, I was wondering if the include should be within the ifdefs or
outside. But since the original code had it inside ifdefs, i thought its
better to have it inside.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/