linux-kernel - Re: [PATCH RESEND 1/1] serial: 8250_pci: Fix real serial port count for F81504/508/512

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VdB0DnAz7TvsrqELJFLd6d9CT+4rjEyzJP7YcH5um_-oA@mail.gmail.com>
Date:	Sun, 20 Dec 2015 19:16:16 +0200
From:	Andy Shevchenko <andy.shevchenko@...il.com>
To:	Peter Hung <hpeter@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jslaby@...e.com>,
	"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	tom_tsai@...tek.com.tw, Peter H <peter_hong@...tek.com.tw>,
	Peter Hung <hpeter+linux_kernel@...il.com>
Subject: Re: [PATCH RESEND 1/1] serial: 8250_pci: Fix real serial port count
 for F81504/508/512

On Tue, Dec 15, 2015 at 4:56 AM, Peter Hung <hpeter@...il.com> wrote:
> Andy Shevchenko 於 2015/12/13 上午 09:08 寫道:
>>
>> On Tue, Dec 1, 2015 at 8:54 AM, Peter Hung <hpeter@...il.com> wrote:
>>> +/* The device is multi-function with UART & GPIO */
>>> +static u8 fintek_gpio_mapping[] = {2, 3, 8, 9, 10, 11};
>>
>>
>> Clearly you have bit combination here
>> Bit 1: 1
>> Bit 3: 1
>>
>> So, mask as 0x0a shall cover this IIAC.
>
>
> IMO, It maybe wrong. If we checked only with 0x0a mask,
> the 0x06 & 0x07 will be passed.

Ah, yes, it will be a bit more than just one check, something like:
(x & 0x0a) && (x & 0x0e != 6)


-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/