linux-kernel - Re: [PATCH] iio: add ad5761 DAC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPybu_153gi5-gq=3Sh8JLpTxTireTw5Q4rnmpdPqYZNUX2BNQ@mail.gmail.com>
Date:	Sun, 20 Dec 2015 12:24:54 +0100
From:	Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
To:	Peter Meerwald-Stadler <pmeerw@...erw.net>
Cc:	Lars-Peter Clausen <lars@...afoo.de>,
	Michael Hennerich <Michael.Hennerich@...log.com>,
	Jonathan Cameron <jic23@...nel.org>,
	Hartmut Knaack <knaack.h@....de>, linux-iio@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iio: add ad5761 DAC driver

Hello Peter:


Thanks for your review! I agree on all your points but one:

On Sat, Dec 19, 2015 at 6:06 PM, Peter Meerwald-Stadler
<pmeerw@...erw.net> wrote:
>> +     .info_mask_separate = BIT(IIO_CHAN_INFO_RAW),   \
>> +     .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SCALE) |  \
>> +             BIT(IIO_CHAN_INFO_OFFSET),              \
>> +     .scan_type = {                                  \
>
> the driver does not support buffered mode, not sure if scan_type should be
> used to store the number of bits; I think it would be cleaner to put this
> in chip_info


Although I understand your point, must of the other dac drivers are
doing the same and in my humble opinion is very elegant.



Best regards!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/