linux-kernel - Re: [PATCH] Documentation: Describe the shared memory usage/accounting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5678187A.5070307@suse.cz>
Date:	Mon, 21 Dec 2015 16:19:22 +0100
From:	Vlastimil Babka <vbabka@...e.cz>
To:	Rodrigo Freire <rfreire@...hat.com>,
	linux-kernel <linux-kernel@...r.kernel.org>
Cc:	linux-mm@...ck.org
Subject: Re: [PATCH] Documentation: Describe the shared memory
 usage/accounting

On 11/19/2015 07:58 PM, Rodrigo Freire wrote:
>
> The Shared Memory accounting support is present in Kernel since
> commit 4b02108ac1b3 ("mm: oom analysis: add shmem vmstat") and in userland
> free(1) since 2014. This patch updates the Documentation to reflect
> this change.
>
> Signed-off-by: Rodrigo Freire <rfreire@...hat.com>

You should send to Andrew Morton and maybe CC Hugh Dickins at the very 
least. Sending just to mailing list doesn't guarantee maintainers will 
pick it up due to the high volume there.
Also note that your RESEND has broken whitespace.


> ---
> --- a/Documentation/filesystems/proc.txt
> +++ b/Documentation/filesystems/proc.txt
> @@ -842,6 +842,7 @@
>   Writeback:           0 kB
>   AnonPages:      861800 kB
>   Mapped:         280372 kB
> +Shmem:             644 kB
>   Slab:           284364 kB
>   SReclaimable:   159856 kB
>   SUnreclaim:     124508 kB
> @@ -898,6 +899,7 @@
>      AnonPages: Non-file backed pages mapped into userspace page tables
>   AnonHugePages: Non-file backed huge pages mapped into userspace page tables
>         Mapped: files which have been mmaped, such as libraries
> +       Shmem: Total memory used by shared memory (shmem) and tmpfs
>           Slab: in-kernel data structures cache
>   SReclaimable: Part of Slab, that might be reclaimed, such as caches
>     SUnreclaim: Part of Slab, that cannot be reclaimed on memory pressure
> --- a/Documentation/filesystems/tmpfs.txt
> +++ b/Documentation/filesystems/tmpfs.txt
> @@ -17,10 +17,10 @@
>   cannot swap and you do not have the possibility to resize them.
>
>   Since tmpfs lives completely in the page cache and on swap, all tmpfs
> -pages currently in memory will show up as cached. It will not show up
> -as shared or something like that. Further on you can check the actual
> -RAM+swap use of a tmpfs instance with df(1) and du(1).
> -
> +pages will be shown in /proc/meminfo as "Shmem" and "Shared" in

It would be IMHO clearer if it said:
... will be shown as "Shmem" in /proc/meminfo and "Shared" in ...

> +free(1). Notice that shared memory pages (see ipcs(1)) will be also
 > +counted as shared memory.

Too much of "shared memory" here. Maybe something like:
"However, these counters also include shared memory (shmem)."

> The most reliable way to get the count is
> +using df(1) and du(1).
>
>   tmpfs has the following uses:
>
> ---
> 1.7.1
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@...ck.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@...ck.org"> email@...ck.org </a>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/