[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-id: <5677662C.6060409@samsung.com>
Date: Mon, 21 Dec 2015 11:38:36 +0900
From: Chanwoo Choi <cw00.choi@...sung.com>
To: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc: Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>,
Mark Rutland <mark.rutland@....com>,
Ian Campbell <ijc+devicetree@...lion.org.uk>,
Kumar Gala <galak@...eaurora.org>,
"myungjoo.ham@...sung.com" <myungjoo.ham@...sung.com>,
devicetree <devicetree@...r.kernel.org>,
linux-kernel <linux-kernel@...r.kernel.org>,
linux-sh@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH v5] extcon: add Maxim MAX3355 driver
Hi,
On 2015년 12월 21일 02:15, Sergei Shtylyov wrote:
> Hello.
>
> On 12/20/2015 05:31 PM, Chanwoo Choi wrote:
>
>> This patch depend on GPIOLIB configuration as following:
>> I modified it with following diff and applied it.
>>
>> diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
>> index ba4db7d..3d89e60 100644
>> --- a/drivers/extcon/Kconfig
>> +++ b/drivers/extcon/Kconfig
>> @@ -54,6 +54,7 @@ config EXTCON_MAX14577
>>
>> config EXTCON_MAX3355
>> tristate "Maxim MAX3355 USB OTG EXTCON Support"
>> + depends on GPIOLIB || COMPILE_TEST
>
> If it won't compile w/o gpiolib, what's the use of COMIPLE_TEST?
> And no, it shouldn't depend on gpiolib. It has empty stubs for the case of CONFIG_GPIOLIB=n. Obviously something is wrong with the GPIO headers, I'll look into it.
Yes. When GPIOLIB is disabled, the build issue don't happen.
because include/linux/gpio/consumer.h implement the dummy function
for all gpio functions if CONFIG_GPIOLIB is disabled.
For correct operation of max3355, you should add the dependency
to the extcon-max3355.c driver. This driver use the GPIO library
certainly.
COMPILE_TEST is used for just build test. You can see the detailed data[1].
[1] https://lkml.org/lkml/2013/5/22/155
Thanks,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists