linux-kernel - Re: [PATCH] ceph: Avoid to propagate the invalid page point

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <801FE0B8-0193-429D-8BB0-E505DDF22E36@redhat.com>
Date:	Mon, 21 Dec 2015 12:12:52 +0800
From:	"Yan, Zheng" <zyan@...hat.com>
To:	Minfei Huang <mnfhuang@...il.com>
Cc:	sage@...hat.com, idryomov@...il.com, ceph-devel@...r.kernel.org,
	linux-kernel@...r.kernel.org, mhuang@...hat.com
Subject: Re: [PATCH] ceph: Avoid to propagate the invalid page point


> On Dec 19, 2015, at 10:54, Minfei Huang <mnfhuang@...il.com> wrote:
> 
> The variant pagep will still get the invalid page point, although ceph
> fails in function ceph_update_writeable_page.
> 
> To fix this issue, Assigne the page to pagep until there is no failure
> in function ceph_update_writeable_page.
> 
> Signed-off-by: Minfei Huang <mnfhuang@...il.com>
> ---
> fs/ceph/addr.c | 1 -
> 1 file changed, 1 deletion(-)
> 
> diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
> index b7d218a..6491079 100644
> --- a/fs/ceph/addr.c
> +++ b/fs/ceph/addr.c
> @@ -1149,7 +1149,6 @@ static int ceph_write_begin(struct file *file, struct address_space *mapping,
> 		page = grab_cache_page_write_begin(mapping, index, 0);
> 		if (!page)
> 			return -ENOMEM;
> -		*pagep = page;
> 
> 		dout("write_begin file %p inode %p page %p %d~%d\n", file,
> 		     inode, page, (int)pos, (int)len);

applied, thanks

Yan, Zheng

> -- 
> 2.6.3
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/