linux-kernel - Re: [PATCH] staging: lustre/lustre/libcfs: Fix type mismatch reported by sparse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151221234443.GA11245@kroah.com>
Date:	Mon, 21 Dec 2015 15:44:43 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Niranjan Dighe <niranjan.dighe@...il.com>
Cc:	Oleg Drokin <oleg.drokin@...el.com>,
	Andreas Dilger <andreas.dilger@...el.com>,
	Dmitry Eremin <dmitry.eremin@...el.com>,
	James Simmons <jsimmons@...radead.org>,
	Mike Rapoport <mike.rapoport@...il.com>,
	Patrick Boettcher <patrick.boettcher@...teo.de>,
	Matthew Tyler <matt.tyler@...shics.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	lustre-devel@...ts.lustre.org
Subject: Re: [PATCH] staging: lustre/lustre/libcfs: Fix type mismatch
 reported by sparse

On Wed, Dec 09, 2015 at 10:38:13PM +0530, Niranjan Dighe wrote:
> The third argument to function kportal_memhog_alloc is expected to
> be gfp_t whereas the actual argument was unsigned int. Fix this by
> explicitly typecasting to gfp_t
> 
> Signed-off-by: Niranjan Dighe <niranjan.dighe@...il.com>
> ---
>  drivers/staging/lustre/lustre/libcfs/module.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/lustre/lustre/libcfs/module.c b/drivers/staging/lustre/lustre/libcfs/module.c
> index 96d9d46..9c79f6e 100644
> --- a/drivers/staging/lustre/lustre/libcfs/module.c
> +++ b/drivers/staging/lustre/lustre/libcfs/module.c
> @@ -268,7 +268,7 @@ static int libcfs_ioctl_int(struct cfs_psdev_file *pfile, unsigned long cmd,
>  			/* XXX The ioc_flags is not GFP flags now, need to be fixed */
>  			err = kportal_memhog_alloc(pfile->private_data,
>  						   data->ioc_count,
> -						   data->ioc_flags);
> +					(__force gfp_t)data->ioc_flags);

No, please fix the type to be correct properly, like the comment says
needs to be done.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/