linux-kernel - [PATCH] trace-cmd: Print relate stacktrace at once

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1450684466-4139-1-git-send-email-namhyung@gmail.com>
Date:	Mon, 21 Dec 2015 16:54:26 +0900
From:	Namhyung Kim <namhyung@...il.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Joonsoo Kim <js1304@...il.com>,
	Namhyung Kim <namhyung@...nel.org>
Subject: [PATCH] trace-cmd: Print relate stacktrace at once

From: Namhyung Kim <namhyung@...nel.org>

Currently trace-cmd prints ring buffer events in a strict time order.
But it sometimes annoying that stacktrace from the same cpu can be
intermixed with events from other cpu.  This patch looks next event when
print last record and prints it also if it's a stacktrace (from the same
cpu).

Requested-by: Joonsoo Kim <js1304@...il.com>
Signed-off-by: Namhyung Kim <namhyung@...nel.org>
---
 trace-read.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/trace-read.c b/trace-read.c
index aec8532..10edf5d 100644
--- a/trace-read.c
+++ b/trace-read.c
@@ -1155,9 +1155,20 @@ static void read_data_info(struct list_head *handle_list, enum output_type otype
 			}
 		}
 		if (last_record) {
+			int last_cpu = last_record->cpu;
+
 			print_handle_file(last_handle);
 			trace_show_data(last_handle->handle, last_record, profile);
 			free_handle_record(last_handle);
+
+			/* print related stacktrace at once */
+			record = tracecmd_peek_data(last_handle->handle, last_cpu);
+			if (record && pevent_data_type(pevent, record) == stacktrace_id &&
+			    test_stacktrace(last_handle, record, 1)) {
+				print_handle_file(last_handle);
+				trace_show_data(last_handle->handle, record, profile);
+				tracecmd_read_data(last_handle->handle, last_cpu);
+			}
 		}
 	} while (last_record);
 
-- 
2.6.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/