linux-kernel - Re: [PATCH v4 2/4] ARM: bcm2835: add rpi power domain driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <877fk7167m.fsf@eliezer.anholt.net>
Date:	Mon, 21 Dec 2015 20:02:21 -0800
From:	Eric Anholt <eric@...olt.net>
To:	Ulf Hansson <ulf.hansson@...aro.org>
Cc:	linux-rpi-kernel@...ts.infradead.org,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	"linux-arm-kernel\@lists.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
	Stephen Warren <swarren@...dotorg.org>,
	Lee Jones <lee@...nel.org>,
	Florian Fainelli <f.fainelli@...il.com>,
	Kevin Hilman <khilman@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Alexander Aring <alex.aring@...il.com>,
	"devicetree\@vger.kernel.org" <devicetree@...r.kernel.org>,
	"linux-pm\@vger.kernel.org" <linux-pm@...r.kernel.org>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>
Subject: Re: [PATCH v4 2/4] ARM: bcm2835: add rpi power domain driver

Ulf Hansson <ulf.hansson@...aro.org> writes:

> On 17 December 2015 at 01:26, Eric Anholt <eric@...olt.net> wrote:
>> From: Alexander Aring <alex.aring@...il.com>
>>
>> This patch adds support for several power domains on Raspberry Pi,
>> including USB (so it can be enabled even if the bootloader didn't do
>> it), and graphics.
>>
>> This patch is the combined work of Eric Anholt (who wrote USB support
>> inside of the Raspberry Pi firmware driver, and wrote the non-USB
>> domain support) and Alexander Aring (who separated the original USB
>> work out from the firmware driver).
>>
>> Signed-off-by: Alexander Aring <alex.aring@...il.com>
>> Signed-off-by: Eric Anholt <eric@...olt.net>
>> ---
>>
>> v2: Add support for power domains other than USB, using the new
>>     firmware interface, reword commit message (changes by Eric)
>>
>> v3: Restructure as a builtin driver, and drop
>>     of_genpd_add_provider_onecell error handling to avoid
>>     pm_genpd_exit() dependency until that API can be settled.  Clean
>>     up copyright header, add missing ISP initialization, and fix typo
>>     in transposer's name.
>>
>> v4: Move to drivers/soc/bcm/, move include to dt-bindings/soc/, set up
>>     Makefile for the drivers/soc/bcm following clk/'s model.
>>
>>  drivers/soc/Kconfig                         |   1 +
>>  drivers/soc/Makefile                        |   1 +
>>  drivers/soc/bcm/Kconfig                     |   9 +
>>  drivers/soc/bcm/Makefile                    |   1 +
>>  drivers/soc/bcm/raspberrypi-power.c         | 247 ++++++++++++++++++++++++++++
>>  include/dt-bindings/soc/raspberrypi-power.h |  41 +++++
>
> There is currently a directory which I think may be better.
> include/dt-bindings/power/*
>
> Besides this nitpick, I think this looks good. You may add my:
>
> Reviewed-by: Ulf Hansson <ulf.hansson@...aro.org>

Thanks!  I'll be sending my pull requests with the two r-bs added and
these nitpicks fixed.

Download attachment "signature.asc" of type "application/pgp-signature" (819 bytes)