linux-kernel - Re: [PATCH v3 23/77] ncr5380: Always retry arbitration and selection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5678F873.2020005@suse.de>
Date:	Tue, 22 Dec 2015 08:14:59 +0100
From:	Hannes Reinecke <hare@...e.de>
To:	Finn Thain <fthain@...egraphics.com.au>,
	"James E.J. Bottomley" <JBottomley@...n.com>,
	Michael Schmitz <schmitzmic@...il.com>,
	linux-m68k@...r.kernel.org, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	"Martin K. Petersen" <martin.petersen@...cle.com>
Subject: Re: [PATCH v3 23/77] ncr5380: Always retry arbitration and selection

On 12/22/2015 02:18 AM, Finn Thain wrote:
> If NCR5380_select() returns -1, it means arbitration was lost or selection
> failed and should be retried. If the main loop simply terminates when there
> are still commands on the issue queue, they will remain queued until they
> expire.
>
> Fix this by clearing the 'done' flag after selection failure or lost
> arbitration.
>
> The "else break" clause in NCR5380_main() that gets removed here appears
> to be a vestige of a long-gone loop that iterated over host instances.
> See commit 491447e1fcff ("[PATCH] next NCR5380 updates") in
> history/history.git.
>
> Signed-off-by: Finn Thain <fthain@...egraphics.com.au>
>
Reviewed-by: Hannes Reinecke <hare@...e.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@...e.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/