linux-kernel - Re: [PATCH v3 26/77] ncr5380: Fix NCR5380_transfer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5678FA40.4040309@suse.de>
Date:	Tue, 22 Dec 2015 08:22:40 +0100
From:	Hannes Reinecke <hare@...e.de>
To:	Finn Thain <fthain@...egraphics.com.au>,
	"James E.J. Bottomley" <JBottomley@...n.com>,
	Michael Schmitz <schmitzmic@...il.com>,
	linux-m68k@...r.kernel.org, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	"Martin K. Petersen" <martin.petersen@...cle.com>
Subject: Re: [PATCH v3 26/77] ncr5380: Fix NCR5380_transfer_pio() result

On 12/22/2015 02:18 AM, Finn Thain wrote:
> According to the SCSI-2 draft revision 10L, atari_NCR5380.c is correct
> when it says that the phase lines are valid up until ACK is negated
> following the transmission of the last byte in MESSAGE IN phase. This is
> true for all information transfer phases, from target to initiator.
>
> Sample the phase bits in STATUS_REG so that NCR5380_transfer_pio() can
> return the correct result. The return value is presently unused (perhaps
> because of bugs like this) but this change at least fixes the caller's
> phase variable, which is passed by reference.
>
> Signed-off-by: Finn Thain <fthain@...egraphics.com.au>
>
> ---
>   drivers/scsi/NCR5380.c       |   12 +++++++++---
>   drivers/scsi/atari_NCR5380.c |   11 ++++++-----
>   2 files changed, 15 insertions(+), 8 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@...e.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@...e.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/