linux-kernel - Re: [PATCH v3 38/77] ncr5380: Remove UNSAFE macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5678FCF1.10305@suse.de>
Date:	Tue, 22 Dec 2015 08:34:09 +0100
From:	Hannes Reinecke <hare@...e.de>
To:	Finn Thain <fthain@...egraphics.com.au>,
	"James E.J. Bottomley" <JBottomley@...n.com>,
	Michael Schmitz <schmitzmic@...il.com>,
	linux-m68k@...r.kernel.org, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	"Martin K. Petersen" <martin.petersen@...cle.com>
Subject: Re: [PATCH v3 38/77] ncr5380: Remove UNSAFE macro

On 12/22/2015 02:18 AM, Finn Thain wrote:
> Configuring core drivers using macros like this one prevents re-unifying
> the core driver forks, and prevents implementing the core driver as a
> library or a platform driver.
>
> The UNSAFE macro in particular is a poor workaround for the problem of
> interrupt latency. Releasing the locks complicates things because then we
> would have to handle the possibility of EH handler invocation during a
> PDMA transfer.
>
> The comments say that instead of using this macro, "you're going to be
> better off twiddling with transfersize". I agree. Remove this stuff.
>
> Signed-off-by: Finn Thain <fthain@...egraphics.com.au>
>
Reviewed-by: Hannes Reinecke <hare@...e.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@...e.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/