linux-kernel - Re: [PATCH v3 41/77] ncr5380: Replace redundant flags with FLAG_NO_DMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5678FE1B.8050302@suse.de>
Date:	Tue, 22 Dec 2015 08:39:07 +0100
From:	Hannes Reinecke <hare@...e.de>
To:	Finn Thain <fthain@...egraphics.com.au>,
	"James E.J. Bottomley" <JBottomley@...n.com>,
	Michael Schmitz <schmitzmic@...il.com>,
	linux-m68k@...r.kernel.org, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	"Martin K. Petersen" <martin.petersen@...cle.com>
Subject: Re: [PATCH v3 41/77] ncr5380: Replace redundant flags with
 FLAG_NO_DMA_FIXUP

On 12/22/2015 02:18 AM, Finn Thain wrote:
> The flags DMA_WORKS_RIGHT, FLAG_NCR53C400 and FLAG_HAS_LAST_BYTE_SENT
> all mean the same thing, i.e. the chip is not a 538[01]. (More recent
> devices such as the 53C80 have a 'Last Byte Sent' bit in the Target
> Command Register as well as other fixes for End-of-DMA errata.)
>
> These flags have no additional meanings since previous cleanup patches
> eliminated the NCR53C400 macro, moved g_NCR5380-specific code out of the
> core driver and standardized interrupt handling.
>
> Use the FLAG_NO_DMA_FIXUP flag to suppress End-of-DMA errata workarounds,
> for those cards and drivers that make use of the TCR_LAST_BYTE_SENT bit.
> Remove the old flags.
>
> Signed-off-by: Finn Thain <fthain@...egraphics.com.au>
>
> ---
>   drivers/scsi/NCR5380.c   |   68 +++++++++++++++--------------------------------
>   drivers/scsi/NCR5380.h   |    4 --
>   drivers/scsi/dtc.c       |    4 --
>   drivers/scsi/g_NCR5380.c |    2 -
>   4 files changed, 25 insertions(+), 53 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@...e.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@...e.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/